Skip to content

Move NEWS entries to pull-request-lifecycle#1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
StanFromIreland wants to merge 10 commits into
base:main
Choose a base branch
from
Open

Move NEWS entries to pull-request-lifecycle #1506

StanFromIreland wants to merge 10 commits into from

Conversation

@StanFromIreland
Copy link
Member

@StanFromIrelandStanFromIreland commented Feb 3, 2025•
edited
Loading

@StanFromIreland
Copy link
MemberAuthor

StanFromIreland commented Feb 3, 2025•
edited
Loading

@hugovk@erlend-aasland@AlexWaygood

@StanFromIreland
Copy link
MemberAuthor

StanFromIreland commented Feb 3, 2025

See also would be nice but it seems to make the section quoted.

hugovk
hugovk reviewed Feb 3, 2025
View reviewed changes
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also would be nice but it seems to make the section quoted.

How do you mean?

StanFromIrelandand others added 2 commits February 3, 2025 20:48
@StanFromIreland@hugovk
Update core-developers/committing.rst
fbd50f0
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@StanFromIreland
seealso works now?
44024a1
@StanFromIreland
Copy link
MemberAuthor

StanFromIreland commented Feb 3, 2025

image

I must have done something weird before it works when I tried again!

hugovk
hugovk approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

picnixz
picnixz reviewed Mar 13, 2025
View reviewed changes
StanFromIrelandand others added 2 commits March 13, 2025 15:33
@StanFromIreland@picnixz
Apply suggestions from code review
d145ed5
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@StanFromIreland
Benedikts suggestions
11b5c8c
picnixz
picnixz approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@picnixzpicnixz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We improved a bit the content, but not by much, so it's fine to make it part of this change. I think we need a follow-up PR to improve the cases where a NEWS entry is necessary (see python/cpython#131177 (comment)). OTOH, you can revert the 3.X.rst mention and make it part of the follow-up PR.

Before merging, I'll check that the rst:role is correctly linked though.

@picnixz
Copy link
Member

picnixz commented Mar 13, 2025

Arf, it appears that we don't have the cross-referencing:

image

Well, let's introduce intersphinx in a future PR.

@StanFromIreland
Merge branch 'main' into move-news
fb346bc
# Conflicts: # core-team/committing.rst
@StanFromIreland
Copy link
MemberAuthor

StanFromIreland commented Sep 13, 2025

Closed the originally linked issue as a duplicate of #674

@StanFromIrelandStanFromIreland linked an issue Sep 13, 2025 that may be closed by this pull request
Sect. 3 (Lifecycle of a Pull Request) does not mention Misc/NEWS.d/next and blurb #674
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes

@picnixzpicnixzpicnixz approved these changes

@methanemethaneAwaiting requested review from methane

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sect. 3 (Lifecycle of a Pull Request) does not mention Misc/NEWS.d/next and blurb

3 participants

@StanFromIreland@picnixz@hugovk