gh-133677: Skip test in test_asyncio if not UTF-8#133719
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sharktide requested review from 1st1, asvetlov, kumaraditya303 and willingc as code owners
sharktide changed the title 
ContributorAuthor
sharktide commented May 8, 2025
Note: the test fail is unrelated |
ContributorAuthor
sharktide commented May 9, 2025
@ZeroIntensity |
Member
serhiy-storchaka commented May 11, 2025
Sorry, but this is not a proper fix of this issue. See #133865. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-133677
#133677 Fixes the
test_asynciofail but not running it if the encoding is not UTF-8similar to #133706 but for
test_asyncio