Skip to content

gh-133677: Fix tests when running in non-UTF-8 locale#133865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 2 commits into from
May 12, 2025
Merged

gh-133677: Fix tests when running in non-UTF-8 locale #133865

serhiy-storchaka merged 2 commits into from
May 12, 2025

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commented May 11, 2025•
edited by bedevere-app bot
Loading

@serhiy-storchakaserhiy-storchaka added the tests Tests in the Lib/test dir label May 11, 2025
@bedevere-appbedevere-appbot mentioned this pull request May 11, 2025
Closed
This was referenced May 11, 2025
Closed
Closed
StanFromIreland
StanFromIreland reviewed May 11, 2025
View reviewed changes
Lib/test/test_asyncio/test_tools.py

deftest_task_awaits_self(self):
"""A task directly awaits itself – should raise a cycle."""
"""A task directly awaits itself - should raise a cycle."""
Copy link
Member

@StanFromIrelandStanFromIrelandMay 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all unrelated.

Copy link
MemberAuthor

@serhiy-storchakaserhiy-storchakaMay 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very related. Error happens when non-ASCII "–" is written to stdout with a non-UTF-8 encoding.

@StanFromIreland
Copy link
Member

StanFromIreland commented May 11, 2025

This is also against the wrong branch, main will be unaffected once #133712

@serhiy-storchakaserhiy-storchaka merged commit 14305a8 into python:mainMay 12, 2025
42 checks passed
@serhiy-storchakaserhiy-storchaka deleted the tests-non-utf8-locale branch May 12, 2025 16:14
@serhiy-storchakaserhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 12, 2025
@miss-islington-app
Copy link

miss-islington-appbot commented May 12, 2025

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-appbot commented May 12, 2025

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 12, 2025
@serhiy-storchaka@miss-islington
pythongh-133677: Fix tests when running in non-UTF-8 locale (pythonGH…
7307ff5
…-133865) (cherry picked from commit 14305a8) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington-app
Copy link

miss-islington-appbot commented May 12, 2025

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 14305a83d381ccdcae814abd9e2c28dda066720b 3.13

@bedevere-app
Copy link

bedevere-appbot commented May 12, 2025

GH-133938 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label May 12, 2025
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 12, 2025
@serhiy-storchaka
[3.13]pythongh-133677: Fix tests when running in non-UTF-8 locale (p…
314ba03
…ythonGH-133865) (cherry picked from commit 14305a8) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-appbot commented May 12, 2025

GH-133939 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label May 12, 2025
@serhiy-storchakaserhiy-storchaka removed their assignment May 12, 2025
serhiy-storchaka added a commit that referenced this pull request May 12, 2025
@miss-islington@serhiy-storchaka
[3.14]gh-133677: Fix tests when running in non-UTF-8 locale (GH-133865…
c11fc4b
…) (GH-133938) (cherry picked from commit 14305a8) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@StanFromIreland
Copy link
Member

StanFromIreland commented May 12, 2025

Relevant buildbot run for this PR: https://buildbot.python.org/#/builders/1678/builds/37 (Not linked by gh at the moment)

serhiy-storchaka added a commit that referenced this pull request May 12, 2025
@serhiy-storchaka
[3.13]gh-133677: Fix tests when running in non-UTF-8 locale (GH-133865…
d9d8e9a
…) (GH-133939) (cherry picked from commit 14305a8)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@serhiy-storchaka@Pranjal095
pythongh-133677: Fix tests when running in non-UTF-8 locale (pythonGH…
5961388
…-133865)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@serhiy-storchaka@taegyunkim
pythongh-133677: Fix tests when running in non-UTF-8 locale (pythonGH…
0ad785c
…-133865)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

@AA-TurnerAA-TurnerAA-Turner approved these changes

@barneygalebarneygaleAwaiting requested review from barneygalebarneygale is a code owner

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

@savannahostrowskisavannahostrowskiAwaiting requested review from savannahostrowskisavannahostrowski is a code owner

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@serhiy-storchaka@StanFromIreland@AA-Turner