Skip to content

gh-115119: Removed bundled copy of the libmpdec#133964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
skirpichev wants to merge 20 commits into from
Closed

gh-115119: Removed bundled copy of the libmpdec #133964

skirpichev wants to merge 20 commits into from

Conversation

@skirpichev
Copy link
Member

@skirpichevskirpichev commented May 13, 2025•
edited by github-actions bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request May 13, 2025
Open
15 tasks
@skirpichevskirpichevforce-pushed the remove-bundled-mpdecimal/115119 branch from 7cba56a to 9d6c9b5CompareMay 13, 2025 15:37
AA-Turner
AA-Turner reviewed May 13, 2025
View reviewed changes
Copy link
Member

@AA-TurnerAA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick comments, haven't looked at build system changes

skirpichevand others added 2 commits May 13, 2025 19:21
@skirpichev@AA-Turner
Apply suggestions from code review
5de2aa2
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@skirpichev
+ configure
dfd9f40
zware
zware previously requested changes May 13, 2025
View reviewed changes
@bedevere-app

This comment was marked as resolved.

Sign in to view
@AA-Turner

This comment was marked as resolved.

Sign in to view
@skirpichev

This comment was marked as resolved.

Sign in to view
@bedevere-app

This comment was marked as resolved.

Sign in to view
@bedevere-appbedevere-appbot requested a review from zwareMay 14, 2025 03:41
@skirpichev

This comment was marked as resolved.

Sign in to view
@skirpichevskirpichevforce-pushed the remove-bundled-mpdecimal/115119 branch from 0a33f9f to 2ba6b8bCompareMay 14, 2025 05:49
@skirpichevskirpichev requested a review from AA-TurnerMay 14, 2025 06:28
@skirpichevskirpichev deleted the remove-bundled-mpdecimal/115119 branch May 16, 2025 04:40
@skirpichevskirpichev restored the remove-bundled-mpdecimal/115119 branch June 3, 2025 02:29
@skirpichevskirpichev reopened this Jun 3, 2025
@skirpichevskirpichev dismissed zware’s stale reviewJune 3, 2025 02:47

Windows changes were reverted

@skirpichevskirpichev mentioned this pull request Jun 3, 2025
Merged
@skirpichevskirpichev deleted the remove-bundled-mpdecimal/115119 branch August 16, 2025 06:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zwarezwareAwaiting requested review from zware

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

@sethmlarsonsethmlarsonAwaiting requested review from sethmlarsonsethmlarson will be requested when the pull request is marked ready for reviewsethmlarson is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently will be requested when the pull request is marked ready for reviewericsnowcurrently is a code owner

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland will be requested when the pull request is marked ready for reviewerlend-aasland is a code owner

@emmatypingemmatypingAwaiting requested review from emmatypingemmatyping will be requested when the pull request is marked ready for reviewemmatyping is a code owner

@corona10corona10Awaiting requested review from corona10corona10 will be requested when the pull request is marked ready for reviewcorona10 is a code owner

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti will be requested when the pull request is marked ready for reviewezio-melotti is a code owner

@hugovkhugovkAwaiting requested review from hugovkhugovk will be requested when the pull request is marked ready for reviewhugovk is a code owner

@webknjazwebknjazAwaiting requested review from webknjazwebknjaz will be requested when the pull request is marked ready for reviewwebknjaz is a code owner

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skirpichev@AA-Turner@zware