Skip to content

gh-115119: defer removal of bundled libmpdec to 3.16#133997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 7 commits into from
Jul 2, 2025
Merged

gh-115119: defer removal of bundled libmpdec to 3.16 #133997

vstinner merged 7 commits into from
Jul 2, 2025

Conversation

@skirpichev
Copy link
Member

@skirpichevskirpichev commented May 14, 2025•
edited by github-actions bot
Loading

@skirpichevskirpichev requested a review from AA-TurnerMay 14, 2025 11:00
@skirpichevskirpichev added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 14, 2025
@bedevere-appbedevere-appbot added the docs Documentation in the Doc dir label May 14, 2025
@bedevere-appbedevere-appbot mentioned this pull request May 14, 2025
Open
15 tasks
StanFromIreland
StanFromIreland reviewed May 14, 2025
View reviewed changes
@skirpichevskirpichev requested a review from hugovkMay 15, 2025 06:47
@skirpichev
Copy link
MemberAuthor

skirpichev commented May 15, 2025

Oops, this seems to be not just a docs patch. I hope this still ok for backport.

@skirpichevskirpichev mentioned this pull request May 16, 2025
Merged
picnixz
picnixz reviewed Jun 2, 2025
View reviewed changes
Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much to say but I'm neutral on delaying the removal.

@hugovkhugovk removed their request for review June 2, 2025 11:06
@vstinner
Copy link
Member

vstinner commented Jun 2, 2025

defer removal of bundled libmpdec to 3.16

What is the rationale for defering the removal?

@skirpichev
Copy link
MemberAuthor

skirpichev commented Jun 2, 2025

What is the rationale for defering the removal?

You can see the issue thread.

For my humble opinion the only excuse is that we miss removal of the implicit fallback to bundled copy (now #134078) in 3.14. (Though, this wasn't announced somewhere else.) We also miss libmpdec in latest ubuntu images. (I think this will be solved before 3.14 release.)

@AA-Turner
Copy link
Member

AA-Turner commented Jun 2, 2025

For my humble opinion the only excuse is that we miss removal of the implicit fallback to bundled copy

I still think we can stick to the original plan (that is: remove the vendored copy in 3.15). The only issue to solve is installing development sources on Ubuntu for 24.04.

@skirpichev
Copy link
MemberAuthor

skirpichev commented Jun 3, 2025

FYI, I restored removal PR: #133964. I think libmpdec can be installed from PPA for PHP.

@skirpichev
Copy link
MemberAuthor

skirpichev commented Jun 11, 2025

Deferring a breaking change is always a good thing :-)

Maybe.

An RM decision isn't needed for normal feature changes in main aka 3.15.

This affects 3.14 as well, as we change announced plans.

@vstinner
Copy link
Member

vstinner commented Jul 1, 2025

Since #134078 was just merged in Python 3.15, I think that it would be safe to postpone the removal to Python 3.16. Have one release with #134078 to see how it goes.

@skirpichev: There are now merge conflicts, can you try to address them?

@skirpichevskirpichev removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 1, 2025
@skirpichev
Copy link
MemberAuthor

skirpichev commented Jul 1, 2025

Oops, now it doesn't make less sense to backport this (configure.ac changes will be manual). It's expected to be merged first, not after #134078.

@skirpichevskirpichev added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 1, 2025
@skirpichevskirpichev requested a review from vstinnerJuly 1, 2025 16:42
@vstinnervstinner removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 2, 2025
@vstinnervstinner merged commit b19c9da into python:mainJul 2, 2025
44 checks passed
@github-project-automationgithub-project-automationbot moved this from Todo to Done in Docs PRsJul 2, 2025
@vstinner
Copy link
Member

vstinner commented Jul 2, 2025

Merged.

Oops, now it doesn't make less sense to backport this (configure.ac changes will be manual).

Do you mean that it doesn't make sense to backport this change, or that it should be backported manually?

@skirpichevskirpichev deleted the defer-libmpdec-removal/115119 branch July 2, 2025 09:32
@skirpichev
Copy link
MemberAuthor

skirpichev commented Jul 2, 2025

Do you mean that it doesn't make sense to backport this change

No, it does!

that it should be backported manually?

Yes. I'll do this.

skirpichev added a commit to skirpichev/cpython that referenced this pull request Jul 2, 2025
@skirpichev
[3.14]pythongh-115119: Defer removal of bundled libmpdec to 3.16 (py…
ac33099
…thonGH-133997) Rename libmpdecimal -> libmpdec see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html (cherry picked from commit b19c9da) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@bedevere-app
Copy link

bedevere-appbot commented Jul 2, 2025

GH-136199 is a backport of this pull request to the 3.14 branch.

skirpichev added a commit to skirpichev/cpython that referenced this pull request Jul 2, 2025
@skirpichev
[3.13]pythongh-115119: Defer removal of bundled libmpdec to 3.16 (py…
79caac3
…thonGH-133997) Rename libmpdecimal -> libmpdec see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html (cherry picked from commit b19c9da) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@bedevere-app
Copy link

bedevere-appbot commented Jul 2, 2025

GH-136201 is a backport of this pull request to the 3.13 branch.

vstinner pushed a commit that referenced this pull request Jul 2, 2025
@skirpichev
[3.14]gh-115119: Defer removal of bundled libmpdec to 3.16 (GH-133997)…
23a990d
… (#136199) Rename libmpdecimal -> libmpdec see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html (cherry picked from commit b19c9da)
vstinner pushed a commit that referenced this pull request Jul 2, 2025
@skirpichev
[3.13]gh-115119: Defer removal of bundled libmpdec to 3.16 (GH-133997)…
1e6db47
… (#136201) Rename libmpdecimal -> libmpdec see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html (cherry picked from commit b19c9da) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@vstinner
Copy link
Member

vstinner commented Jul 2, 2025

I merged the 3.13 and 3.14 backports, thanks.

AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@skirpichev@AndPuQing
pythongh-115119: Defer removal of bundled libmpdec to 3.16 (python#13…
d9021b2
…3997) Rename libmpdecimal -> libmpdec see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@skirpichev@Pranjal095
pythongh-115119: Defer removal of bundled libmpdec to 3.16 (python#13…
22b9910
…3997) Rename libmpdecimal -> libmpdec see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
@skirpichev@picnixz
pythongh-115119: Defer removal of bundled libmpdec to 3.16 (python#13…
98d96e0
…3997) Rename libmpdecimal -> libmpdec see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@skirpichev@taegyunkim
pythongh-115119: Defer removal of bundled libmpdec to 3.16 (python#13…
a6f3560
…3997) Rename libmpdecimal -> libmpdec see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@skirpichev@Agent-Hellboy
pythongh-115119: Defer removal of bundled libmpdec to 3.16 (python#13…
175adab
…3997) Rename libmpdecimal -> libmpdec see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland approved these changes

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

@picnixzpicnixzAwaiting requested review from picnixz

@vstinnervstinnerAwaiting requested review from vstinner

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@skirpichev@vstinner@AA-Turner@hugovk@picnixz@StanFromIreland