Skip to content

gh-134584: Eliminate redundant refcounting from _CALL_STR_1#136070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Fidget-Spinner merged 6 commits into from
Dec 14, 2025
Merged

gh-134584: Eliminate redundant refcounting from _CALL_STR_1#136070

Fidget-Spinner merged 6 commits into from
Dec 14, 2025

Conversation

@Zheaoli
Copy link
Contributor

@ZheaoliZheaoli commented Jun 28, 2025•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Jun 28, 2025
Closed
35 tasks
@Zheaoli
fix ci
a8057aa
Signed-off-by: Manjusaka <[email protected]>
@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented Jun 28, 2025

Thanks! This looks great to me. Just waiting for Mark's PR on TOS caching to get merged.

Fidget-Spinner
Fidget-Spinner reviewed Dec 11, 2025
View reviewed changes
@Zheaoli
fix review idea
5636c72
Signed-off-by: Manjusaka <[email protected]>
@Zheaoli
merge main
53cef9d
Signed-off-by: Manjusaka <[email protected]>
@ZheaoliZheaoli mentioned this pull request Dec 12, 2025
Merged
Fidget-Spinner
Fidget-Spinner reviewed Dec 13, 2025
View reviewed changes
@Zheaoli
Copy link
ContributorAuthor

Zheaoli commented Dec 14, 2025

@Fidget-Spinner Thanks for your time, I have update the PR like what we do in #142604

BTW just for personal interest, May I ask why we revert the code generator change in #142604 ?

Fidget-Spinner
Fidget-Spinner approved these changes Dec 14, 2025
View reviewed changes
Copy link
Member

@Fidget-SpinnerFidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This is great!

@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented Dec 14, 2025

BTW just for personal interest, May I ask why we revert the code generator change in #142604 ?

I realised we can get the same thing with ERROR_NO_POP, so there's no point to do it.

@Fidget-SpinnerFidget-Spinner merged commit a154c9e into python:mainDec 14, 2025
74 checks passed
@Zheaoli
Copy link
ContributorAuthor

Zheaoli commented Dec 14, 2025

I realised we can get the same thing with ERROR_NO_POP, so there's no point to do it.

Got it! Thanks your time!

@ZheaoliZheaoli deleted the manjusaka/refcount-call-str branch December 14, 2025 09:35
fatelei pushed a commit to fatelei/cpython that referenced this pull request Dec 16, 2025
@Zheaoli@fatelei
pythongh-134584: Eliminate redundant refcounting from_CALL_STR_1(p…
8203fe0
…ythonGH-136070) Signed-off-by: Manjusaka <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes

@tomasr8tomasr8Awaiting requested review from tomasr8tomasr8 is a code owner

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Zheaoli@Fidget-Spinner@markshannon