gh-134584: Revert partially #135860#142620
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
35 tasks
Contributor
Zheaoli commented Dec 12, 2025
Should I change #136070 to avoid the refleak? |
vstinner approved these changes Dec 12, 2025
Member
vstinner left a comment
vstinner left a comment There was a problem hiding this comment.
LGTM: I confirm that this change fix the refleak. I didn't review the change itself, it just looks good to me :-)
$ ./python -m test test.test_multiprocessing_fork.test_threads -R 3:3 (...) Result: SUCCESS MemberAuthor
Fidget-Spinner commented Dec 12, 2025
Fidget-Spinner merged commit a3a611b into python:main 72 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a refleak.