Skip to content

gh-132661: PEP 750 documentation: second pass#137020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AA-Turner merged 5 commits into from
Aug 4, 2025
Merged

gh-132661: PEP 750 documentation: second pass #137020

AA-Turner merged 5 commits into from
Aug 4, 2025

Conversation

@AA-Turner
Copy link
Member

@AA-TurnerAA-Turner commented Jul 22, 2025•
edited by github-actions bot
Loading

@AA-TurnerAA-Turner added the needs backport to 3.14 bugs and security fixes label Jul 22, 2025
@bedevere-appbedevere-appbot added awaiting core review docs Documentation in the Doc dir labels Jul 22, 2025
@bedevere-appbedevere-appbot mentioned this pull request Jul 22, 2025
Closed
@AA-TurnerAA-Turner mentioned this pull request Jul 22, 2025
Merged
@StanFromIrelandStanFromIreland mentioned this pull request Jul 23, 2025
Closed
encukou
encukou reviewed Jul 23, 2025
View reviewed changes
@davepeck
Copy link
Contributor

davepeck commented Jul 24, 2025•
edited
Loading

Overall these changes look great to me. Thanks @AA-Turner !

About my only detail comment is that I tried to avoid using commas in examples so the reprs were easier to read. Hence "Hello World" without the comma. I'd be happy to see cheese-based examples make a comeback. :-)

(Sorry for the slow review. I'm out of town on vacation right now -- back in another week.)

@brianschubertbrianschubert mentioned this pull request Jul 28, 2025
Closed
@davepeckdavepeck mentioned this pull request Jul 31, 2025
Closed
@AA-Turner
Copy link
MemberAuthor

AA-Turner commented Aug 4, 2025

Thank you for the reviews @encukou@davepeck!

A

@AA-TurnerAA-Turner merged commit 4dae9b1 into python:mainAug 4, 2025
25 checks passed
@github-project-automationgithub-project-automationbot moved this from Todo to Done in Docs PRsAug 4, 2025
@miss-islington-app
Copy link

miss-islington-appbot commented Aug 4, 2025

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@AA-TurnerAA-Turner deleted the docs/pep-750-second-pass branch August 4, 2025 21:45
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 4, 2025
@AA-Turner@miss-islington
pythongh-132661: PEP 750 documentation: second pass (pythonGH-137020)
8079f8e
(cherry picked from commit 4dae9b1) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-appbot commented Aug 4, 2025

GH-137392 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Aug 4, 2025
hugovk pushed a commit that referenced this pull request Aug 16, 2025
@miss-islington@AA-Turner
[3.14]gh-132661: PEP 750 documentation: second pass (GH-137020) (#13…
e817d1a
…7392) gh-132661: PEP 750 documentation: second pass (GH-137020) (cherry picked from commit 4dae9b1) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@AA-Turner@Agent-Hellboy
pythongh-132661: PEP 750 documentation: second pass (python#137020)
f633708
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington@AA-Turner@kumaraditya303
[3.14]pythongh-132661: PEP 750 documentation: second pass (pythonGH-…
948f7e3
…137020) (python#137392) pythongh-132661: PEP 750 documentation: second pass (pythonGH-137020) (cherry picked from commit 4dae9b1) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukouencukouencukou left review comments

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

+1 more reviewer

@JessicaTegnerJessicaTegnerJessicaTegner left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AA-Turner@davepeck@encukou@JessicaTegner