gh-138013: Move test.test_io to be a module#138153
Merged
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets up for having a test_io._support which contains the I/O mocks for sharing between multiple
iomodule test files. Also starts a path for all theiomodule tests to live in a single module for simpler running rather than requiring knowledge of the list ofiotests which lives in a comment intest_io.Common test invocatoins (ex.
python -m test test_io -uall -M8Gandpython -m test.test_io) run the same set of tests after this change as before.I copied
__init__.pyand__main__.pyfrom other python test sub directory instances; happy to tweak if needed.It is possible to split out the Buffered I/O tests without moving
test_ioto be a module. In that case still will need a module where the common "mocks" live (My tentative plan istest.test_io._support). I think this sets up for more understandable structure to theiotests overall, but happy to explore the problem space if desired.