Skip to content

gh-138013: Move test.test_io to be a module#138153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AA-Turner merged 1 commit into from
Aug 31, 2025
Merged

gh-138013: Move test.test_io to be a module #138153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Lib/test/test_io/__init__.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
importos
fromtest.supportimportload_package_tests

defload_tests(*args):
returnload_package_tests(os.path.dirname(__file__), *args)
4 changes: 4 additions & 0 deletions Lib/test/test_io/__main__.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
from . import load_tests
import unittest

unittest.main()
2 changes: 1 addition & 1 deletion Lib/test/test_io.py → Lib/test/test_io/test_general.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,7 @@
# * test_memoryio - tests BytesIO and StringIO
# * test_fileio - tests FileIO
# * test_file - tests the file interface
# * test_io - tests everything else in the io module
# * test_io.test_general - tests everything else in the io module
# * test_univnewlines - tests universal newline support
# * test_largefile - tests operations on a file greater than 2**32 bytes
Comment on lines 5 to 10
Copy link
Member

@AA-TurnerAA-TurnerAug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the modules here be moved into the new package?

Copy link
ContributorAuthor

@cmaloneycmaloneyAug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My plan is yes over time, just limiting scope of changes (and PRs) to pieces I'm actively working on changing (Currently Buffered I/O layer). test_bufio I plan to do as part of this overall issue (gh-138013). Not sure how much people rely on the names currently (ex. tracking performance over time by measuring test runtime). Unfortunately there are no benchmarks for CPython I/O in pyperformance currently (is part of my backlog to add).

Copy link
Member

@AA-TurnerAA-TurnerAug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests can and do move around, we don't make any guarantees here. Performance tests should use the pyperformance suite.

# (only enabled with -ulargefile)
Expand Down
1 change: 1 addition & 0 deletions Makefile.pre.in
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2669,6 +2669,7 @@ TESTSUBDIRS= idlelib/idle_test \
test/test_importlib/source \
test/test_inspect \
test/test_interpreters \
test/test_io \
test/test_json \
test/test_module \
test/test_multiprocessing_fork \
Expand Down
Loading