gh-139716: StackRef tests are added#139717

efimov-mikhail · 2025-10-07T18:16:29Z

New test file Lib/test/test_stackrefs.py introduced.
Some auxillary functions are added to _testinternalcapi.
Those functions are examples of correct StackRef scenarios.
We check that all refcounts remain correct.
And that results are the same for equivalent scenarios.

Issue: Add tests on basic PyStackRef functions #139716

efimov-mikhail · 2025-10-07T18:17:26Z

CC @markshannon @Fidget-Spinner @mpage

Lib/test/test_stackrefs.py

markshannon

Looks good. I've one concern about code organization, but that's all.

Modules/_testinternalcapi.c

bedevere-app · 2025-10-27T15:47:35Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

efimov-mikhail · 2025-10-27T16:24:20Z

I have made the requested changes; please review again.

bedevere-app · 2025-10-27T16:24:26Z

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.

efimov-mikhail · 2025-11-13T18:45:27Z

Failure was because of #131229

efimov-mikhail · 2025-11-15T18:57:08Z

Friendly ping, @markshannon @Fidget-Spinner .
Maybe I should make another change to this PR?

Fidget-Spinner

Just two questions

Include/internal/pycore_stackref.h

Lib/test/test_stackrefs.py

efimov-mikhail · 2025-11-17T16:16:12Z

Include/internal/pycore_stackref.h

+_PyStackRef_AsTuple(_PyStackRef ref, PyObject *op)
+{
+ // Do not check StackRef flags in the free threading build.
+ return Py_BuildValue("(ni)", Py_REFCNT(op), -1);


Actually, I've realized that we could remove this special case.
It's related only to stackrefs for immortal objects at ft build.
We can make a little change for _PyStackRef_FromPyObjectSteal and for PyStackRef_FromPyObjectNew function: add Py_TAG_DEFERRED flag to references on immortal objects.
All tests passed with this change on my machine.
But I suggest doing this in the next small PR, and keep only tests changes here.

I've created a #141675 for this change.

Lib/test/test_stackrefs.py

Modules/_testinternalcapi.c

Lib/test/test_stackrefs.py

Modules/_testinternalcapi.c

sergey-miryanov

Thanks!

efimov-mikhail · 2025-12-20T17:43:34Z

CC @markshannon @Fidget-Spinner @colesbury
Could we merge this?

Another option is merge #143024 first and adapt tests for that change here.

efimov-mikhail added 2 commits October 7, 2025 20:01

First variant of stackref tests
f1b3c94

Fixes for Py_STACKREF_DEBUG build
871c013

bedevere-appbot added tests Tests in the Lib/test dir awaiting review labels Oct 7, 2025

bedevere-appbot mentioned this pull request Oct 7, 2025
Add tests on basic PyStackRef functions #139716
Open

Improvements
0a82e96

efimov-mikhail mentioned this pull request Oct 7, 2025
Document _PyStackRef #124379
Closed

StanFromIreland reviewed Oct 7, 2025
View reviewed changes

Lib/test/test_stackrefs.pyShow resolvedHide resolved

Do not check flags on FT build
a5e39e8

StanFromIreland added the skip news label Oct 7, 2025

Merge branch 'main' into stackref_tests
f2bd853

markshannon requested changes Oct 27, 2025
View reviewed changes

Modules/_testinternalcapi.c Outdated Show resolvedHide resolved

bedevere-appbot added awaiting changes and removed awaiting review labels Oct 27, 2025

efimov-mikhail requested a review from Fidget-Spinner as a code owner October 27, 2025 16:24

bedevere-appbot added awaiting change review and removed awaiting changes labels Oct 27, 2025

bedevere-appbot requested a review from markshannon October 27, 2025 16:24

Review addressed
6feef7a

efimov-mikhail marked this pull request as draft October 27, 2025 19:05

bedevere-appbot removed the awaiting change review label Oct 27, 2025

efimov-mikhail marked this pull request as ready for review October 27, 2025 19:05

bedevere-appbot added the awaiting review label Oct 27, 2025

efimov-mikhail added 3 commits October 27, 2025 22:08

Merge branch 'main' into stackref_tests
577c137

Build fix
6390e57

Merge branch 'main' into stackref_tests
e5ec87c

efimov-mikhail mentioned this pull request Nov 14, 2025
gh-141536: Fix a crash when running test_capi *after* test_code in the same process #141537
Merged

Merge branch 'main' into stackref_tests
e45d254

Fidget-Spinner reviewed Nov 16, 2025
View reviewed changes

Include/internal/pycore_stackref.h Outdated Show resolvedHide resolved
Lib/test/test_stackrefs.py Outdated Show resolvedHide resolved

efimov-mikhail added 5 commits November 17, 2025 17:06

Changes in Py_BuildValue calls
b1b3b2b

Changes in Py_BuildValue calls 2
d965529

Improvements in test
77c88bb

Improvements in test 2
06fe751

Remove blank line
c9ae051

efimov-mikhail commented Nov 17, 2025
View reviewed changes

Use -1 in flags only for immortal objects on ft build
474f650

efimov-mikhail requested review from Fidget-Spinner, StanFromIreland and sergey-miryanov November 17, 2025 18:08

efimov-mikhail mentioned this pull request Nov 17, 2025
gh-139716: Use the same StackRef flagging scheme for immortals on FT build as on GIL build #141675
Closed

sergey-miryanov reviewed Nov 17, 2025
View reviewed changes

Lib/test/test_stackrefs.pyShow resolvedHide resolved

efimov-mikhail added 4 commits November 17, 2025 21:48

Rename obj -> res in aux functions
5274122

Use constants in test
2471609

Remove blank line
36a2fb4

Asserts on mortality
14521a1

sergey-miryanov reviewed Nov 17, 2025
View reviewed changes

efimov-mikhail added 2 commits November 17, 2025 22:05

Comment change
db34b87

Comments improvement
63ea804

efimov-mikhail requested a review from sergey-miryanov November 18, 2025 13:31

sergey-miryanov approved these changes Nov 18, 2025
View reviewed changes

efimov-mikhail added 3 commits November 18, 2025 16:58

Merge branch 'main' into stackref_tests
72ec253

Merge branch 'main' into stackref_tests
b927d08

Lint fix
2998fed

Uh oh!

gh-139716: StackRef tests are added#139717

Are you sure you want to change the base?

gh-139716: StackRef tests are added #139717

Uh oh!

Conversation

efimov-mikhail commented Oct 7, 2025• edited by bedevere-app botLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

efimov-mikhail commented Oct 7, 2025

Uh oh!

Uh oh!

markshannon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-appbot commented Oct 27, 2025

Uh oh!

efimov-mikhail commented Oct 27, 2025

Uh oh!

bedevere-appbot commented Oct 27, 2025

Uh oh!

efimov-mikhail commented Nov 13, 2025

Uh oh!

efimov-mikhail commented Nov 15, 2025

Uh oh!

Fidget-Spinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

efimov-mikhailNov 17, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

efimov-mikhailNov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sergey-miryanov left a comment

Choose a reason for hiding this comment

Uh oh!

efimov-mikhail commented Dec 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

efimov-mikhail commented Oct 7, 2025•
edited by bedevere-app bot
Loading

efimov-mikhailNov 17, 2025•
edited
Loading