Skip to content

gh-141536: Fix a crash when running test_capi *after* test_code in the same process#141537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Yhg1s merged 3 commits into from
Jan 7, 2026
Merged

gh-141536: Fix a crash when running test_capi *after* test_code in the same process #141537

Yhg1s merged 3 commits into from
Jan 7, 2026

Conversation

@Yhg1s
Copy link
Member

@Yhg1sYhg1s commented Nov 13, 2025•
edited by bedevere-app bot
Loading

@Yhg1sYhg1s added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 13, 2025
@bedevere-appbedevere-appbot added awaiting core review tests Tests in the Lib/test dir labels Nov 13, 2025
@bedevere-appbedevere-appbot mentioned this pull request Nov 13, 2025
Closed
@efimov-mikhail
Copy link
Member

efimov-mikhail commented Nov 14, 2025•
edited
Loading

There's CI problem with test_import for UBSan build. I have two sequential problems on my PR:
#139717

See also #141545, #131229

vstinner
vstinner reviewed Nov 14, 2025
View reviewed changes
meta-codesyncbot pushed a commit to facebookincubator/cinder that referenced this pull request Nov 20, 2025
@drinkmorewaterr@meta-codesync
Add patch '17-gh-pr-141537' to third-party/python/3.14
9875ce1
Summary: We need this PR to resolve a segfault - python/cpython#141537 Patching it in now since it may be some time before it lands in upstream + get backported to 3.14 This diff adds a patch to the `third-party/python/3.14` Meta-internal fork. Fix a crash when running test_capi *after* test_code in the same process Reviewed By: itamaro Differential Revision: D87464010 fbshipit-source-id: 79e515ab5733a365ef52c821b06c59f59ded0a7a
itamaro
itamaro approved these changes Jan 4, 2026
View reviewed changes
Copy link
Contributor

@itamaroitamaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about late_deletion in test.support!

vstinner
vstinner approved these changes Jan 7, 2026
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I confirm that this change fix the issue #141536.

@Yhg1sYhg1s merged commit b2827de into python:mainJan 7, 2026
48 checks passed
@miss-islington-app
Copy link

miss-islington-appbot commented Jan 7, 2026

Thanks @Yhg1s for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 7, 2026
@Yhg1s@miss-islington
pythongh-141536: Fix a crash when running test_capi *after* test_code…
f739b43
… in the same process (pythonGH-141537) (cherry picked from commit b2827de) Co-authored-by: T. Wouters <thomas@python.org>
@miss-islington-app
Copy link

miss-islington-appbot commented Jan 7, 2026

Sorry, @Yhg1s, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker b2827de18fe88152dc38c1aa76c39b69ef59cb6f 3.13

@bedevere-app
Copy link

bedevere-appbot commented Jan 7, 2026

GH-143522 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Jan 7, 2026
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Jan 9, 2026
@Yhg1s@StanFromIreland
[3.13]pythongh-141536: Fix a crash when running test_capi *after* te…
51f49bc
…st_code in the same process (pythonGH-141537) (cherry picked from commit b2827de) Co-authored-by: T. Wouters <thomas@python.org>
@bedevere-app
Copy link

bedevere-appbot commented Jan 9, 2026

GH-143625 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Jan 9, 2026
kumaraditya303 pushed a commit that referenced this pull request Jan 10, 2026
@miss-islington@Yhg1s
[3.14]gh-141536: Fix a crash when running test_capi *after* test_cod…
bf3ed37
…e in the same process (GH-141537) (#143522) gh-141536: Fix a crash when running test_capi *after* test_code in the same process (GH-141537) (cherry picked from commit b2827de) Co-authored-by: T. Wouters <thomas@python.org>
serhiy-storchaka pushed a commit that referenced this pull request Jan 12, 2026
@StanFromIreland@Yhg1s
[3.13]gh-141536: Fix a crash when running test_capi *after* test_cod…
8a09b51
…e in the same process (GH-141537) (GH-143625) (cherry picked from commit b2827de) Co-authored-by: T. Wouters <thomas@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@itamaroitamaroitamaro approved these changes

Assignees

@Yhg1sYhg1s

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Yhg1s@efimov-mikhail@vstinner@itamaro