Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-140287: Handle PYTHONSTARTUP script exceptions in the asyncio REPL#140288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base:main
Are you sure you want to change the base?
gh-140287: Handle PYTHONSTARTUP script exceptions in the asyncio REPL #140288
Uh oh!
There was an error while loading. Please reload this page.
Conversation
johnslavik commented Oct 18, 2025 • edited by bedevere-app bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-app bot
Uh oh!
There was an error while loading. Please reload this page.
johnslavik commented Oct 23, 2025
Please merge #140298 first. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
johnslavik commented Dec 16, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Looks like I was confused about the regression -- that's good news! This will have to wait until the loop is properly closed in the asyncio REPL. |
johnslavik commented Dec 16, 2025
johnslavik commented Dec 16, 2025
It does! Cool! |
This reverts commit 875fd2a.
| except SystemExit: | ||
| raise |
johnslavikDec 20, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't like this, but it resembles the original behavior of the REPLs -- see GH-143023.
I don't think this is correct, but it's not super clear to me, so please chime in to GH-143023 to put your two cents in.
| exceptSystemExit: | |
| raise | |
| # TODO: Revisit in GH-143023 | |
| exceptSystemExit: | |
| raise |
johnslavikDec 20, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GH-143023 is also why I didn't add a test for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've got some good news, this is not bad! I'll add a test shortly.
johnslavik commented Dec 21, 2025
I'll see if I can simplify this. I think the tests are slightly overcomplicated. |
johnslavik left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll come back to this after completing GH-140648.
johnslavik commented Jan 4, 2026
I've realized that this isn't testing what it is supposed to test. I'll come back to this later. |
This is generally a work in progress; tests are needed.
The asyncio patch is simple and ready.
PYTHONSTARTUPexceptions #140287