Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-140438: Properly run the asyncio REPL in REPL tests#140298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-140438: Properly run the asyncio REPL in REPL tests #140298
Uh oh!
There was an error while loading. Please reload this page.
Conversation
johnslavik commented Oct 18, 2025 • edited by bedevere-app bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-app bot
Uh oh!
There was an error while loading. Please reload this page.
ZeroIntensity commented Oct 18, 2025
I think it would be good if you created an issue for this. |
johnslavik commented Oct 21, 2025
@ZeroIntensity done; let's remove the |
johnslavik commented Oct 23, 2025
cc @asvetlov |
ZeroIntensity commented Oct 23, 2025
@kumaraditya303 is our primary asyncio maintainer at the moment. Kumar, are you familiar enough with the asyncio REPL to review this? |
kumaraditya303 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1a3da2c into python:mainUh oh!
There was an error while loading. Please reload this page.
Thanks @bswck for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
(cherry picked from commit 1a3da2c) Co-authored-by: Bartosz Sławecki <[email protected]>
(cherry picked from commit 1a3da2c) Co-authored-by: Bartosz Sławecki <[email protected]>
GH-140507 is a backport of this pull request to the 3.14 branch. |
GH-140508 is a backport of this pull request to the 3.13 branch. |
bedevere-bot commented Oct 23, 2025
|
Mixing
-iwith-m asynciofirst spawns the asyncio REPL. After asyncio REPL exits, it spawns the regular Python REPL.Here we're introducing more idiomatic way to test other custom REPLs in
test_replas necessary, without needing a pseudo-terminal.CC @ZeroIntensity (mentorship):
skip issue,skip news,needs backport to 3.13,needs backport to 3.14.-iflag is mixed with custom REPLs in tests #140438