Skip to content

gh-142764: Restore REPLACE_OPCODE_IF_EVALUATES_PURE optimization#143335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Fidget-Spinner merged 5 commits into from
Jan 9, 2026
Merged

gh-142764: Restore REPLACE_OPCODE_IF_EVALUATES_PURE optimization #143335

Fidget-Spinner merged 5 commits into from
Jan 9, 2026

Conversation

@Fidget-Spinner
Copy link
Member

@Fidget-SpinnerFidget-Spinner commented Jan 1, 2026•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Jan 1, 2026
Closed
@Fidget-SpinnerFidget-Spinner mentioned this pull request Jan 1, 2026
Closed
35 tasks
@Zheaoli
Copy link
Contributor

Zheaoli commented Jan 6, 2026

I think #143417 depends on this PR If I'm correct.

@ZheaoliZheaoli mentioned this pull request Jan 6, 2026
Merged
savannahostrowski
savannahostrowski reviewed Jan 9, 2026
View reviewed changes
savannahostrowski
savannahostrowski approved these changes Jan 9, 2026
View reviewed changes
Copy link
Member

@savannahostrowskisavannahostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think otherwise, this LGTM!

@Fidget-SpinnerFidget-Spinner merged commit 9525911 into python:mainJan 9, 2026
79 checks passed
@Fidget-SpinnerFidget-Spinner deleted the replace_opcodes_Fix branch January 9, 2026 23:18
@Fidget-Spinner
Copy link
MemberAuthor

Fidget-Spinner commented Jan 9, 2026

Thanks for the review!

reidenong pushed a commit to reidenong/cpython that referenced this pull request Jan 12, 2026
@Fidget-Spinner@reidenong
pythongh-142764: Restore REPLACE_OPCODE_IF_EVALUATES_PURE optimizatio…
7fe6e67
…n for some ops (pythonGH-143335)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@savannahostrowskisavannahostrowskisavannahostrowski approved these changes

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

@tomasr8tomasr8Awaiting requested review from tomasr8tomasr8 is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Interaction of refcount elimination and constant propagation is complex to handle

3 participants

@Fidget-Spinner@Zheaoli@savannahostrowski