gh-134584: Eliminate redundant refcounting from TO_BOOL_STR

[Zheaoli]

• Issue: Eliminate redundant refcounting in the JIT #134584

[Fidget-Spinner]

Pretty close

[Fidget-Spinner]

This optimization is broken because the stack effect changed,

You need to fix optimize_to_bool to allow for an insert mode, so it should be the same as the one in her https://github.com/python/cpython/pull/143335/files (see _INSERT_1_LOAD_CONST_INLINE_BORROW)

So optimize_to_bool(this_instr, ctx, value, &res, true);, where true is for insert_mode, which will change to opcode to _INSERT_1_LOAD_CONST_INLINE_BORROW

[Fidget-Spinner]

I can do this change, as it's a little more complex

[Zheaoli]

Thanks for the suggestion! TIL

I may need a little bit time to update the patch(lol

[Zheaoli]

I can do this change, as it's a little more complex

If this is possible, I would like to make this change!

[Fidget-Spinner]

Sure!

[Zheaoli]

I have complete the code on my local branch, not push. Because I have some issue about this part

I think the patch, I will use _INSERT_1_LOAD_CONST_INLINE_BORROW but this is made in #143335

For now, I add a tier2 op named _INSERT_1_LOAD_CONST_INLINE_BORROW copy from #143335. I'm not sure if this is OK?

[Fidget-Spinner]

Yeah just copy the op over

[Fidget-Spinner]

Please fix the merge conflicts. Thanks!

[Zheaoli]

Please fix the merge conflicts. Thanks!

Sorry about this, seems new commit merged in main. Fixed