[doc] Leverage the fact that the actual types can now be indexed for typing#22340
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
andresdelfino requested review from gvanrossum and ilevkivskyi as code owners
andresdelfino changed the title 
gvanrossum approved these changes Sep 27, 2020
Member
gvanrossum left a comment
gvanrossum left a comment There was a problem hiding this comment.
Thanks! At first I was hesitant to approve this, because people will want to write code that's backwards compatible for a few versions, but they should just read the old docs...
Member
gvanrossum commented Sep 27, 2020
Travis reporting is stuck, and it prevents me from overriding, so I'm going to close and reopen in the hope that fixes it. (There's quite a chance that it doesn't.) |
Member
gvanrossum commented Sep 27, 2020
@Mariatta What's the trick to landing this? |
ContributorAuthor
@gvanrossum it may be the Travis CI build, which is queued. It seems there was a problem with Travis reporting the build state to GitHub, as all jobs are done in Travis: https://travis-ci.com/github/python/cpython/builds/185656276 GitHub is waiting for that build to end since I opened the PR. |
Member
gvanrossum commented Sep 27, 2020
If you can, read the issue that references this. There’s a GitHub bug that prevents it from seeing the reported status, and some kind of super permission that I don’t have is needed to bypass that. :-( |
Contributor
miss-islington commented Sep 27, 2020
@andresdelfino: Status check is done, and it's a success ✅ . |
1 similar comment
Contributor
miss-islington commented Sep 27, 2020
@andresdelfino: Status check is done, and it's a success ✅ . |
Contributor
miss-islington commented Sep 27, 2020
Sorry, I can't merge this PR. Reason: |
1 similar comment
Contributor
miss-islington commented Sep 27, 2020
Sorry, I can't merge this PR. Reason: |
ContributorAuthor
andresdelfino commented Sep 27, 2020
Just pushed an empty commit to try to unlock the Travis build. |
Contributor
miss-islington commented Sep 27, 2020
@andresdelfino: Status check is done, and it's a success ✅ . |
Contributor
miss-islington commented Sep 27, 2020
Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2020
…typing (pythonGH-22340) This shows users that they can use the actual types. Using deprecated types is confusing. This also prefers colections.abc.Sized instead of the alias typing.Sized. I guess the aliases were created to make it convenient to import all collections related types from the same place. This should be backported to 3.9. Automerge-Triggered-By: @gvanrossum (cherry picked from commit d9ab95f) Co-authored-by: Andre Delfino <adelfino@gmail.com>
bedevere-bot commented Sep 27, 2020
GH-22430 is a backport of this pull request to the 3.9 branch. |
miss-islington added a commit that referenced this pull request Sep 27, 2020
…typing (GH-22340) This shows users that they can use the actual types. Using deprecated types is confusing. This also prefers colections.abc.Sized instead of the alias typing.Sized. I guess the aliases were created to make it convenient to import all collections related types from the same place. This should be backported to 3.9. Automerge-Triggered-By: @gvanrossum (cherry picked from commit d9ab95f) Co-authored-by: Andre Delfino <adelfino@gmail.com>
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Sep 29, 2020
* origin/master: (113 commits) bpo-41773: Raise exception for non-finite weights in random.choices(). (pythonGH-22441) bpo-41873: Add vectorcall for float() (pythonGH-22432) bpo-41861: Convert _sqlite3 PrepareProtocolType to heap type (pythonGH-22428) bpo-41842: Add codecs.unregister() function (pythonGH-22360) bpo-41875: Use __builtin_unreachable when possible (pythonGH-22433) bpo-40105: ZipFile truncate in append mode with shorter comment (pythonGH-19337) bpo-41870: Use PEP 590 vectorcall to speed up bool() (pythonGH-22427) [doc] Leverage the fact that the actual types can now be indexed for typing (pythonGH-22340) bpo-41861: Convert _sqlite3 cache and node static types to heap types (pythonGH-22417) bpo-41858: Clarify line in optparse doc (pythonGH-22407) Revert "Fix all Python Cookbook links (python#22205)" (pythonGH-22424) bpo-1635741: Port _bisect module to multi-phase init (pythonGH-22415) bpo-41428: Fix compiler warning in unionobject.c (pythonGH-22416) Fix logging error message (pythonGH-22410) bpo-39934: Account for control blocks in 'except' in compiler. (pythonGH-22395) bpo-41775: Make 'IDLE Shell' the shell title (python#22399) bpo-41428: Fix compiler warnings in unionobject.c (pythonGH-22388) bpo-41654: Fix compiler warning in MemoryError_dealloc() (pythonGH-22387) bpo-41833: threading.Thread now uses the target name (pythonGH-22357) bpo-30155: Add macros to get tzinfo from datetime instances (pythonGH-21633) ...
miss-islington pushed a commit that referenced this pull request Oct 3, 2020
…H-22524) This changes a few occurrences left behind by #22340. Automerge-Triggered-By: @gvanrossum
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2020
…ythonGH-22524) This changes a few occurrences left behind by pythonGH-22340. Automerge-Triggered-By: @gvanrossum (cherry picked from commit 7f54e56) Co-authored-by: Andre Delfino <adelfino@gmail.com>
miss-islington added a commit that referenced this pull request Oct 3, 2020
…H-22524) This changes a few occurrences left behind by GH-22340. Automerge-Triggered-By: @gvanrossum (cherry picked from commit 7f54e56) Co-authored-by: Andre Delfino <adelfino@gmail.com>
ambv pushed a commit to ambv/cpython that referenced this pull request Oct 4, 2020
…typing (pythonGH-22340) This shows users that they can use the actual types. Using deprecated types is confusing. This also prefers colections.abc.Sized instead of the alias typing.Sized. I guess the aliases were created to make it convenient to import all collections related types from the same place. This should be backported to 3.9. Automerge-Triggered-By: @gvanrossum (cherry picked from commit d9ab95f) Co-authored-by: Andre Delfino <adelfino@gmail.com>
ambv pushed a commit to ambv/cpython that referenced this pull request Oct 4, 2020
…ythonGH-22524) This changes a few occurrences left behind by pythonGH-22340. Automerge-Triggered-By: @gvanrossum (cherry picked from commit 7f54e56) Co-authored-by: Andre Delfino <adelfino@gmail.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
…typing (pythonGH-22340) This shows users that they can use the actual types. Using deprecated types is confusing. This also prefers colections.abc.Sized instead of the alias typing.Sized. I guess the aliases were created to make it convenient to import all collections related types from the same place. This should be backported to 3.9. Automerge-Triggered-By: @gvanrossum
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
…ythonGH-22524) This changes a few occurrences left behind by python#22340. Automerge-Triggered-By: @gvanrossum
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shows users that they can use the actual types. Using deprecated types is confusing.
This also prefers colections.abc.Sized instead of the alias typing.Sized. I guess the aliases were created to make it convenient to import all collections related types from the same place.
This should be backported to 3.9.
Automerge-Triggered-By: @gvanrossum