[3.9] [doc] Leverage the fact that the actual types can now be indexed for typing (GH-22340)#22430
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…typing (pythonGH-22340) This shows users that they can use the actual types. Using deprecated types is confusing. This also prefers colections.abc.Sized instead of the alias typing.Sized. I guess the aliases were created to make it convenient to import all collections related types from the same place. This should be backported to 3.9. Automerge-Triggered-By: @gvanrossum (cherry picked from commit d9ab95f) Co-authored-by: Andre Delfino <adelfino@gmail.com>
miss-islington requested review from gvanrossum and ilevkivskyi as code owners
bedevere-bot added skip issue skip news docs 
ContributorAuthor
miss-islington commented Sep 27, 2020
@andresdelfino: Status check is done, and it's a success ✅ . |
gvanrossum approved these changes Sep 27, 2020
Member
gvanrossum left a comment
gvanrossum left a comment There was a problem hiding this comment.
(And thanks for finding a way to unblock the master PR!)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shows users that they can use the actual types. Using deprecated types is confusing.
This also prefers colections.abc.Sized instead of the alias typing.Sized. I guess the aliases were created to make it convenient to import all collections related types from the same place.
This should be backported to 3.9.
Automerge-Triggered-By: @gvanrossum
(cherry picked from commit d9ab95f)
Co-authored-by: Andre Delfino adelfino@gmail.com