Skip to content

Conversation

@andresdelfino
Copy link
Contributor

@andresdelfinoandresdelfino commented Dec 17, 2020

The issue being resolved is shown in the 3.10 docs (if you select docs for older versions you won't see a visual glitch).

The newer sphinx version that produces the 3.10 docs doesn't treat the backslash to escape things in some situations it previously did..
(cherry picked from commit dcc997c)

Co-authored-by: Andre Delfino adelfino@gmail.com

Automerge-Triggered-By: GH:Mariatta

…GH-23658) The issue being resolved is shown in the 3.10 docs (if you select docs for older versions you won't see a visual glitch). The newer sphinx version that produces the 3.10 docs doesn't treat the backslash to escape things in some situations it previously did.. (cherry picked from commit dcc997c) Co-authored-by: Andre Delfino <adelfino@gmail.com>
@andresdelfino
Copy link
ContributorAuthor

@Mariatta perhaps we can merge this?

Copy link

@ghostghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@MariattaMariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@JulienPalard
Copy link
Member

As in the 3.8 and 3.9 branch we don't use the newer Sphinx, this commit drops the backslashes :( I think this should be reverted, are you ok for a revert @andresdelfino ?

@andresdelfino
Copy link
ContributorAuthor

@JulienPalard this commit doesn't affect how the doc is rendered for 3.8/3.9, but I think it's good to have consistency with master (to prevent conflicts for future commits).

@JulienPalard
Copy link
Member

@andresdelfino I just tried locally a first build on the top of 3.9, I have:

print(*objects, sep=' ', end='n', file=sys.stdout, flush=False) 

and then reverted e89993c, build again, and I now have:

print(*objects, sep=' ', end='\n', file=sys.stdout, flush=False) 

so looks like e89993c made the backslash dissapear (see here in prod: https://docs.python.org/3.9/library/functions.html#print)

@andresdelfino
Copy link
ContributorAuthor

@JulienPalard oh, yes, you are right; this should be reverted. Sorry!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@andresdelfino@JulienPalard@Mariatta@the-knights-who-say-ni@bedevere-bot@miss-islington