[3.8] bpo-42822: Revert "[3.8] [doc] Fix erroneous backslashes in signatures and names (GH-23658)"#24093
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
JulienPalard requested review from a team, 1st1, asvetlov and gpshead as code owners
MemberAuthor
JulienPalard commented Jan 4, 2021
Hum no, a full revert is not needed, only some bits has to be reverted, let me check this in details. |
JulienPalardforce-pushed the revert-23828-backport-dcc997c-3.8 branch from 43bcae7 to bcacd9dCompareMemberAuthor
JulienPalard commented Jan 4, 2021
@andresdelfino Same here, I kept only backslashes involved in strings, so in one hand we keep the difference as small as possible between versions (easing backports), while keeping the doc right. I hope I picked the right ones, I still did not took the time to build it locally to visually check every change (I'm at $DAYJOB lunch break ;p). |
JulienPalard changed the title JulienPalard changed the title 
Contributor
andresdelfino commented Jan 4, 2021
@JulienPalard I compared your changes with the ones introduced and found all of the problematic ones fixed :) |
JulienPalard added a commit to JulienPalard/cpython that referenced this pull request Jan 21, 2021
…onGH-23658)" (pythonGH-24093) This partially reverts commit 02349e2, which was removing backslashes in documentations compiled with Sphinx < 3, used for Python 3.8 and 3.9 docs.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #23828 due to python/python-docs-theme#63
https://bugs.python.org/issue42822