bpo-43693: Compute deref offsets in compiler#25152
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
3 tasks
Uh oh!
There was an error while loading. Please reload this page.
Member
serhiy-storchaka left a comment
serhiy-storchaka left a comment There was a problem hiding this comment.
Update also Doc/library/dis.rst.
Member
serhiy-storchaka commented Apr 5, 2021
Please don't forget to bump a bytecode magic number and add a line to the bytecode history list. |
ericsnowcurrentlyforce-pushed the compile-deref-offsets-in-compiler branch 2 times, most recently from 6e4b212 to 8045347Compareericsnowcurrentlyforce-pushed the compile-deref-offsets-in-compiler branch from 16546b6 to 6174448CompareMemberAuthor
markshannon commented May 19, 2021
Eric is working on a PR to implement faster-cpython/ideas#41, so I'm closing this. |
This was referenced May 27, 2021
ericsnowcurrentlyforce-pushed the compile-deref-offsets-in-compiler branch from 6174448 to 46d531eCompare
Member
gvanrossum commented Jun 3, 2021
(What are you doing here?) |
Member
ericsnowcurrently commented Jun 3, 2021
This change was always going to be included. I figured it would still be cleaner if it were its own PR. It also makes the subsequent PR a little smaller. (Plus it was already reviewed, between Mark and me, so I'll merge it today. 🙂) |
pablogsal added a commit to pablogsal/cpython that referenced this pull request Jun 4, 2021
This reverts commit b2bf2bc.
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Jun 7, 2021
These were reverted in pythonGH-26530 (commit 17c4edc). * Compute deref offsets in compiler (pythongh-25152) * Add new internal code objects fields: co_fastlocalnames and co_fastlocalkinds. (pythongh-26388)
ericsnowcurrently added a commit that referenced this pull request Jun 7, 2021
These were reverted in gh-26530 (commit 17c4edc) due to refleaks. * 2c1e258 - Compute deref offsets in compiler (gh-25152) * b2bf2bc - Add new internal code objects fields: co_fastlocalnames and co_fastlocalkinds. (gh-26388) This change fixes the refleaks. https://bugs.python.org/issue43693
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges locals and cells into a single array.
Saves a pointer in the interpreter and means that we don't need the
LOAD_CLOSUREopcode any morehttps://bugs.python.org/issue43693