Skip to content

bpo-43693: Revert commits 2c1e2583fdc4db6b43d163239ea42b0e8394171f and b2bf2bc1ece673d387341e06c8d3c2bc6e259747 #26530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 2 commits into from
Jun 4, 2021
Merged

bpo-43693: Revert commits 2c1e2583fdc4db6b43d163239ea42b0e8394171f and b2bf2bc1ece673d387341e06c8d3c2bc6e259747 #26530

pablogsal merged 2 commits into from
Jun 4, 2021

Conversation

@pablogsal
Copy link
Member

@pablogsalpablogsal commented Jun 4, 2021•
edited by bedevere-bot
Loading

@pablogsalpablogsal requested a review from tiran as a code ownerJune 4, 2021 16:32
@pablogsal
Copy link
MemberAuthor

pablogsal commented Jun 4, 2021

The leaks are fixed after the revert:

❯ ./python -m test test_code -R : 0:00:00 load avg: 5.88 Run tests sequentially 0:00:00 load avg: 5.88 [1/1] test_code beginning 9 repetitions 123456789 ......... == Tests result: SUCCESS == 1 test OK. Total duration: 709 ms Tests result: SUCCESS master on  main [$?⇡]  pyenv 3.9.1 ❯ ./python -m test test_exceptions -R : 0:00:00 load avg: 5.88 Run tests sequentially 0:00:00 load avg: 5.88 [1/1] test_exceptions beginning 9 repetitions 123456789 ......... == Tests result: SUCCESS == 1 test OK. Total duration: 21.7 sec Tests result: SUCCESS

@pablogsalpablogsal merged commit 17c4edc into python:mainJun 4, 2021
@pablogsalpablogsal deleted the revert-bpo-43693 branch June 4, 2021 16:51
@ericsnowcurrentlyericsnowcurrently mentioned this pull request Jun 7, 2021
Merged
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Jun 7, 2021
@ericsnowcurrently
Un-revert commits2c1e258andb2bf2bc.
5e98b69
These were reverted in pythonGH-26530 (commit 17c4edc). * Compute deref offsets in compiler (pythongh-25152) * Add new internal code objects fields: co_fastlocalnames and co_fastlocalkinds. (pythongh-26388)
ericsnowcurrently added a commit that referenced this pull request Jun 7, 2021
@ericsnowcurrently
bpo-43693: Un-revert commits 2c1e258 andb2bf2bc. (gh-26577)
2ab27c4
These were reverted in gh-26530 (commit 17c4edc) due to refleaks. * 2c1e258 - Compute deref offsets in compiler (gh-25152) * b2bf2bc - Add new internal code objects fields: co_fastlocalnames and co_fastlocalkinds. (gh-26388) This change fixes the refleaks. https://bugs.python.org/issue43693
@markshannonmarkshannon mentioned this pull request May 2, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

@tirantiranAwaiting requested review from tiran

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pablogsal@the-knights-who-say-ni@bedevere-bot