[3.10] bpo-44098: Drop ParamSpec from most __parameters__ in typing generics (GH-26013)#26091
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…rics (pythonGH-26013) Added two new attributes to ``_GenericAlias``: * ``_typevar_types``, a single type or tuple of types indicating what types are treated as a ``TypeVar``. Used for ``isinstance`` checks. * ``_paramspec_tvars ``, a boolean flag which guards special behavior for dealing with ``ParamSpec``. Setting it to ``True`` means this class deals with ``ParamSpec``. Automerge-Triggered-By: GH:gvanrossum (cherry picked from commit b2f3f8e) Co-authored-by: Ken Jin <[email protected]>
ContributorAuthor
miss-islington commented May 13, 2021
@Fidget-Spinner: Status check is done, and it's a success ✅ . |
3 similar comments
ContributorAuthor
miss-islington commented May 13, 2021
@Fidget-Spinner: Status check is done, and it's a success ✅ . |
ContributorAuthor
miss-islington commented May 13, 2021
@Fidget-Spinner: Status check is done, and it's a success ✅ . |
ContributorAuthor
miss-islington commented May 13, 2021
@Fidget-Spinner: Status check is done, and it's a success ✅ . |
gvanrossum approved these changes May 13, 2021
bedevere-bot commented May 13, 2021
@gvanrossum: Please replace |
Contributor
posita commented Jan 29, 2022
I know this was merged awhile ago, but should this have included an update to |
Member
gvanrossum commented Jan 29, 2022
Could you please open a bpo issue about that? |
Contributor
posita commented Jan 30, 2022
bpo-46581 filed. |
posita added a commit to posita/cpython that referenced this pull request Mar 10, 2022
pythonGH-26091 added the _typevar_types and _paramspec_tvars instance variables to _GenericAlias. However, they were not propagated consistently. This commit addresses the most prominent deficiency identified in bpo-46581 (namely their absence from _GenericAlias.copy_with), but there could be others.
serhiy-storchaka added a commit that referenced this pull request Mar 10, 2022
GH-26091 added the _typevar_types and _paramspec_tvars instance variables to _GenericAlias. However, they were not propagated consistently. This commit addresses the most prominent deficiency identified in bpo-46581 (namely their absence from _GenericAlias.copy_with), but there could be others. Co-authored-by: Ken Jin <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
posita added a commit to posita/cpython that referenced this pull request Mar 11, 2022
…ythonGH-31061) (Cherry-picked from 32bf359.) pythonGH-26091 added the _typevar_types and _paramspec_tvars instance variables to _GenericAlias. However, they were not propagated consistently. This commit addresses the most prominent deficiency identified in bpo-46581 (namely their absence from _GenericAlias.copy_with), but there could be others. Co-authored-by: Ken Jin <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Mar 11, 2022
…H-31061) (GH-31821) (Cherry-picked from 32bf359.) GH-26091 added the _typevar_types and _paramspec_tvars instance variables to _GenericAlias. However, they were not propagated consistently. This commit addresses the most prominent deficiency identified in bpo-46581 (namely their absence from _GenericAlias.copy_with), but there could be others. Co-authored-by: Ken Jin <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]> Co-authored-by: Ken Jin <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two new attributes to
_GenericAlias:_typevar_types, a single type or tuple of types indicating what types are treated as aTypeVar. Used forisinstancechecks._paramspec_tvars, a boolean flag which guards special behavior for dealing withParamSpec. Setting it toTruemeans this class deals withParamSpec.Automerge-Triggered-By: GH:gvanrossum
(cherry picked from commit b2f3f8e)
Co-authored-by: Ken Jin [email protected]
https://bugs.python.org/issue44098
Automerge-Triggered-By: GH:gvanrossum