Skip to content

bpo-44165: optimise sqlite3 statement preparation by passing string size#26206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 5 commits into from
Jun 2, 2021
Merged

bpo-44165: optimise sqlite3 statement preparation by passing string size #26206

pablogsal merged 5 commits into from
Jun 2, 2021

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commented May 18, 2021•
edited
Loading

Quoting the SQLite docs, https://sqlite.org/c3ref/prepare.html:
"If the caller knows that the supplied string is nul-terminated, then
there is a small performance advantage to passing an nByte parameter
that is the number of bytes in the input string including the
nul-terminator."

https://bugs.python.org/issue44165

@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented May 18, 2021

@pablogsal I recon this can pass as skip news. This is an internal micro-optimisation only. No user visible change.

pablogsal
pablogsal reviewed May 19, 2021
View reviewed changes
pablogsal
pablogsal reviewed May 19, 2021
View reviewed changes
@pablogsalpablogsal merged commit a384b6c into python:mainJun 2, 2021
pablogsal
pablogsal reviewed Jun 2, 2021
View reviewed changes
pablogsal
pablogsal reviewed Jun 2, 2021
View reviewed changes
@erlend-aaslanderlend-aasland deleted the sqlite-prepare branch June 2, 2021 12:30
@pythonpython deleted a comment from bedevere-botJun 2, 2021
@pythonpython deleted a comment from bedevere-botJun 2, 2021
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Jun 2, 2021

This PR was broken by fffa0f9. I'll resolve the issues in a new PR.

erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jun 2, 2021
pysqlite_statement_create now returns a Py object, not an int
448ad9d
pythonGH-26206 was broken by pythonGH-26475.
@erlend-aaslanderlend-aasland mentioned this pull request Jun 2, 2021
Merged
pablogsal pushed a commit that referenced this pull request Jun 2, 2021
bpo-44165: pysqlite_statement_create now returns a Py object, not an …
fbf25b8
…int (GH-26484) GH-26206 was broken by GH-26475.
@erlend-aaslanderlend-aasland mentioned this pull request May 16, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal approved these changes

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@pablogsal@the-knights-who-say-ni@bedevere-bot