bpo-44337: Port LOAD_ATTR to PEP 659 adaptive interpreter#26595
Uh oh!
There was an error while loading. Please reload this page.
Conversation
… in dictionary when specializing.
markshannon added the 🔨 test-with-buildbots 
bedevere-bot commented Jun 8, 2021
🤖 New build scheduled with the buildbot fleet by @markshannon for commit f9e999c 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot removed the 🔨 test-with-buildbots 
markshannon added the 🔨 test-with-buildbots bedevere-bot commented Jun 9, 2021
🤖 New build scheduled with the buildbot fleet by @markshannon for commit b07f219 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot removed the 🔨 test-with-buildbots markshannon added the 🔨 test-with-buildbots bedevere-bot commented Jun 9, 2021
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 6d9ef8d 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot removed the 🔨 test-with-buildbots 
@markshannon You may want to check out https://bugs.python.org/msg395432 . This shows that the ASAN failures are not false positives as there is obviously something corrupted and we are reading that memory. |
markshannon commented Jun 9, 2021
Hopefully #26626 will fix the address sanitizer failures |
markshannon added the 🔨 test-with-buildbots bedevere-bot commented Jun 9, 2021
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 41cb98f 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot removed the 🔨 test-with-buildbots 
| DEOPT_IF(res==NULL, LOAD_ATTR); | ||
| STAT_INC(loadattr_hit); | ||
| record_cache_hit(cache0); | ||
| STAT_INC(loadattr_hit); |
There was a problem hiding this comment.
Just casually reading through some of the code, it looks like the STAT_INC(loadattr_hit); is duplicated here (see two lines up).
6 participants
Implements four specializations of
LOAD_ATTR:LOAD_ATTR_SLOTfor slots.LOAD_ATTR_SPLIT_KEYSfor attributes in instance dictionaries that have split keys.LOAD_ATTR_HINTfor attributes in instance dictionaries that do not have split keys.LOAD_ATTR_MODULEfor module attributesThere are more specializations of
LOAD_ATTRthat we want to implement, but this PR is large enough already.https://bugs.python.org/issue44337