bpo-43693: Do not check co_cell2arg if a non-cell offset.#26626
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
markshannon commented Jun 9, 2021
@ericsnowcurrently have you run the tests with the address sanitizer on this? |
MemberAuthor
ericsnowcurrently commented Jun 9, 2021
@markshannon, I did not. However, I figured this would take care of the problem and the buildbot results for the merge indicate it did. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same fix as for
PyFrame_LocalsToFast()in gh-26609, but applied toPyFrame_FastToLocalsWithError(). (It should have been in that PR.)https://bugs.python.org/issue43693