bpo-43693: Un-revert commit f3fa63e.#26609
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…cals offsets. (pythongh-26396)" That commit (3fe921c) was reverted in pythonGH-26597 (3fe921c).
ericsnowcurrently added the 🔨 test-with-buildbots 
bedevere-bot commented Jun 8, 2021
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 5107da7 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot removed the 🔨 test-with-buildbots 
pablogsal approved these changes Jun 8, 2021
Member
pablogsal commented Jun 8, 2021
Thanks for the quick fix, @ericsnowcurrently |
bedevere-bot commented Jun 8, 2021
@ericsnowcurrently: Please replace |
ericsnowcurrently added a commit that referenced this pull request Jun 9, 2021
This is the same fix as for PyFrame_LocalsToFast() in gh-26609, but applied to PyFrame_FastToLocalsWithError(). (It should have been in that PR.) https://bugs.python.org/issue43693
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was reverted in GH-26596 (commit 6d518bb) due to some bad memory accesses.
The memory accesses have been fixed and I verified the address sanitizer is happy now (after duplicating the failure locally).
https://bugs.python.org/issue43693