bpo-44490: Improve typing module compatibility with types.Union#27048

uriyyo · 2021-07-06T19:26:52Z

https://bugs.python.org/issue44490

uriyyo · 2021-07-06T19:27:08Z

@Fidget-Spinner Could you please review this PR?

Fidget-Spinner · 2021-07-06T23:42:40Z

@Fidget-Spinner Could you please review this PR?

The Python typing parts LGTM. But I need to do some revision for the C parts.

Fidget-Spinner · 2021-07-07T14:09:26Z

Hmm I wonder if it would be better if you split out the pure Python changes (like the nested __parameters__ search in typing) from the C+Python changes into a separate PR.

My reasoning follows that the Python changes can easily be backported. The C changes not so much and will require much more deliberation. What do you think Guido? @gvanrossum

gvanrossum · 2021-07-07T14:30:22Z

Agreed, this currently looks like two independent changes. See also the NEWS file.

uriyyo · 2021-07-07T14:54:31Z

@Fidget-Spinner @gvanrossum Thats makes sense. I will convert this PR into containing only typing fixes and will open another PR.

uriyyo · 2021-07-07T18:03:30Z

@Fidget-Spinner Could you please review this PR?

Fidget-Spinner

LGTM. Some minor questions and comments below.

Lib/typing.py

Misc/NEWS.d/next/Core and Builtins/2021-07-06-22-22-15.bpo-44490.BJxPbZ.rst

Lib/test/test_typing.py

…90.BJxPbZ.rst Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>

uriyyo · 2021-07-12T08:43:17Z

@Fidget-Spinner Could you please review this PR?

Fidget-Spinner

Yurii, sorry for the delay. Was a little busy. This LGTM. Thanks for submitting this PR.

BTW, it looks like the C changes to types.Union in the other PR won't make to 3.10 (we missed the beta 4 deadline). So we don't have to worry about backporting anymore.

uriyyo · 2021-07-12T10:50:20Z

Thanks for review, should we mention those changes at What's new section?

Fidget-Spinner · 2021-07-12T11:22:30Z

Thanks for review, should we mention those changes at What's new section?

Yes I was just thinking about that ;). I recommend we mention in whatsnew for 3.11 that union now supports nested type parameters.

uriyyo · 2021-07-12T12:10:52Z

Great, should it be done at separate PR?

Fidget-Spinner · 2021-07-12T12:18:00Z

Great, should it be done at separate PR?

Please do! I don't think the other C changes to fix typing.Annotated are whatsnew worthy. So you can start on it.

uriyyo · 2021-07-14T20:20:34Z

@gvanrossum Could you please review this PR?

gvanrossum

Great work! I will merge.

gvanrossum · 2021-07-17T03:35:09Z

@Fidget-Spinner Do you think this is worth a backport to 3.10? IIUC @serhiy-storchaka is backporting his types.Union improvements.

Fidget-Spinner · 2021-07-17T03:41:19Z

I think it's worth a backport but we can't since the PR adding __parameters__#26980 was never backported.

gvanrossum · 2021-07-17T03:44:05Z

Never mind then. I guess that’s fine.

Fidget-Spinner · 2021-07-18T02:27:12Z

Thanks to Serhiy's Mass Cleanup, we can now backport this.

miss-islington · 2021-07-18T02:27:28Z

Thanks @uriyyo for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

bedevere-bot · 2021-07-18T02:27:53Z

GH-27220 is a backport of this pull request to the 3.10 branch.

…onGH-27048) (cherry picked from commit bf89ff9) Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>

…7048) (#27222) (cherry picked from commit bf89ff9) Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>

bpo-44490: Fix various issues with types.Union
f5b3570

uriyyo requested review from gvanrossum and ilevkivskyi as code owners July 6, 2021 19:26

the-knights-who-say-ni added the CLA signed label Jul 6, 2021

bedevere-bot added the awaiting review label Jul 6, 2021

Fix repr test
0bc1800

uriyyo added 3 commits July 7, 2021 20:53

Remove types.Union serialezation
d699211

Remove test_union_pickle
a00bfb4

Add more tests to cover types.Union
4ad9b66

Fidget-Spinner reviewed Jul 8, 2021
View reviewed changes

Lib/typing.pyShow resolvedHide resolved
Misc/NEWS.d/next/Core and Builtins/2021-07-06-22-22-15.bpo-44490.BJxPbZ.rst Outdated Show resolvedHide resolved
Lib/test/test_typing.py Outdated Show resolvedHide resolved

Update Misc/NEWS.d/next/Core and Builtins/2021-07-06-22-22-15.bpo-444…
140a41a
…90.BJxPbZ.rst Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>

uriyyo changed the title ~~bpo-44490: Fix various issues with types.Union~~bpo-44490: Improve typing module compatibility with types.UnionJul 8, 2021

uriyyoand others added 3 commits July 8, 2021 20:50

Update Lib/test/test_typing.py
6826d72
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>

Update typing tests
8b36d36

Update tests
4081113

uriyyo requested a review from Fidget-Spinner July 8, 2021 18:02

Update tests
b92ba0d

Fidget-Spinner approved these changes Jul 12, 2021
View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels Jul 12, 2021

gvanrossum approved these changes Jul 17, 2021
View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Jul 17, 2021

gvanrossum merged commit bf89ff9 into python:mainJul 17, 2021

bedevere-bot removed the awaiting merge label Jul 17, 2021

Fidget-Spinner removed the request for review from ilevkivskyi July 18, 2021 02:27

Fidget-Spinner added the needs backport to 3.10 only security fixes label Jul 18, 2021

bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 18, 2021

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 18, 2021
bpo-44490: Improve typing module compatibility with types.Union (pyth…
4ed37b5
…onGH-27048) (cherry picked from commit bf89ff9) Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>

gvanrossum pushed a commit that referenced this pull request Jul 19, 2021
bpo-44490: Improve typing module compatibility with types.Union (GH-2…
a272164
…7048) (#27222) (cherry picked from commit bf89ff9) Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>

Uh oh!

bpo-44490: Improve typing module compatibility with types.Union#27048

bpo-44490: Improve typing module compatibility with types.Union #27048

Uh oh!

Conversation

uriyyo commented Jul 6, 2021• edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

uriyyo commented Jul 6, 2021

Uh oh!

Fidget-Spinner commented Jul 6, 2021

Uh oh!

Fidget-Spinner commented Jul 7, 2021

Uh oh!

gvanrossum commented Jul 7, 2021

Uh oh!

uriyyo commented Jul 7, 2021

Uh oh!

uriyyo commented Jul 7, 2021

Uh oh!

Fidget-Spinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

uriyyo commented Jul 12, 2021

Uh oh!

Fidget-Spinner left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

uriyyo commented Jul 12, 2021

Uh oh!

Fidget-Spinner commented Jul 12, 2021

Uh oh!

uriyyo commented Jul 12, 2021

Uh oh!

Fidget-Spinner commented Jul 12, 2021

Uh oh!

uriyyo commented Jul 14, 2021

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

gvanrossum commented Jul 17, 2021

Uh oh!

Fidget-Spinner commented Jul 17, 2021

Uh oh!

gvanrossum commented Jul 17, 2021

Uh oh!

Fidget-Spinner commented Jul 18, 2021

Uh oh!

miss-islington commented Jul 18, 2021

Uh oh!

bedevere-bot commented Jul 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

uriyyo commented Jul 6, 2021•
edited by bedevere-bot
Loading

Fidget-Spinner left a comment •
edited
Loading