[3.10] bpo-44490: Improve typing module compatibility with types.Union (GH-27048)#27222
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…onGH-27048) (cherry picked from commit bf89ff9) Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
Fidget-Spinner changed the title 
serhiy-storchaka approved these changes Jul 18, 2021
gvanrossum approved these changes Jul 19, 2021
Member
gvanrossum left a comment
gvanrossum left a comment There was a problem hiding this comment.
Yeah, looks good to me too.
What happens next? Will it be merged automatically? Does Pablo need to do it? Can we do it?
MemberAuthor
Fidget-Spinner commented Jul 19, 2021
I think so. I asked Pablo the previous time because that change was quite big, touched lots of C code and added new features. This time, it's smaller, only touching Python code, and IMO it's a bug. Without this fix we can't mix and match the Union type and typing types. |
bedevere-bot commented Jul 19, 2021
@gvanrossum: Please replace |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit bf89ff9)
Co-authored-by: Yurii Karabas 1998uriyyo@gmail.com
https://bugs.python.org/issue44490