bpo-45464: [doc] Explain that subclassing multiple exceptions is fragile#29094
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
pablogsal commented Oct 20, 2021
This reads much better than the other one. I am convinced. I'm closing the other one |
pablogsal approved these changes Oct 20, 2021
Member
pablogsal left a comment
pablogsal left a comment There was a problem hiding this comment.
LGTM
Left a comment. Thanks a lot for making this PR!
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Pablo Galindo Salgado <[email protected]>
terryjreedy approved these changes Oct 20, 2021
Member
terryjreedy left a comment
terryjreedy left a comment There was a problem hiding this comment.
This is more detail than I was suggesting, but wording looks fine to me.
Contributor
miss-islington commented Oct 20, 2021
Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
bedevere-bot commented Oct 20, 2021
GH-29104 is a backport of this pull request to the 3.10 branch. |
bedevere-bot removed needs backport to 3.10 bedevere-bot commented Oct 20, 2021
GH-29105 is a backport of this pull request to the 3.9 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2021
…ile (pythonGH-29094) Co-authored-by: Pablo Galindo Salgado <[email protected]> (cherry picked from commit dff0b71) Co-authored-by: Łukasz Langa <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2021
…ile (pythonGH-29094) Co-authored-by: Pablo Galindo Salgado <[email protected]> (cherry picked from commit dff0b71) Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit that referenced this pull request Oct 20, 2021
…ile (GH-29094) (GH-29104) Co-authored-by: Pablo Galindo Salgado <[email protected]> (cherry picked from commit dff0b71) Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit that referenced this pull request Oct 20, 2021
…ile (GH-29094) (GH-29105) Co-authored-by: Pablo Galindo Salgado <[email protected]> (cherry picked from commit dff0b71) Co-authored-by: Łukasz Langa <[email protected]>
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Oct 21, 2021
* main: (263 commits) bpo-45521: Fix a bug in the obmalloc radix tree code. (pythonGH-29051) bpo-45522: Allow to disable freelists on build time (pythonGH-29056) bpo-34451: Document prompt and output toggle feature in html tutorial (pythonGH-27105) bpo-44019: Add operator.call() to __all__ for the operator module (pythonGH-29110) bpo-45315: PyType_FromSpec: Copy spec->name and have the type own the memory for its name (pythonGH-29103) bpo-44220: Export PyStructSequence_UnnamedField in the limited API (pythonGH-26331) bpo-44174: [Enum] add reference to name mangling (pythonGH-29116) bpo-45548: add some missing entries to `Modules/Setup` (pythonGH-29115) bpo-35673: Add a public alias for namespace package __loader__ attribute (python#29049) bpo-45192: Fix a bug that infers the type of an os.PathLike[bytes] object as str (pythonGH-28323) bpo-45527: Don't count cache hits, just misses. (pythonGH-29092) bpo-45320: Remove long-deprecated inspect methods (pythonGH-28618) bpo-41374: Remove obsolete exclusion of netinet/tcp.h on Cygwin (pythonGH-21649) bpo-45532: Replace 'default' with 'main' as default in sys.version (pythonGH-29100) bpo-45464: [doc] Explain that subclassing multiple exceptions is fragile (pythonGH-29094) Cleanup a couple of comments left on PR 28775 post-merge. (pythonGH-29079) bpo-45536: Check OpenSSL APIs in configure (pythonGH-29088) Add PEPs 593 & 647 to list of PEPs at top of typing docs (pythonGH-29097) Add a comment about how to fix bogus test_host_resolution_bad_address failures (python#29085) bpo-44525: Specialize simple Python calls. (pythonGH-29033) ...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to GH-28995 which avoids using a
warningbox, instead using the recommended affirmative tone. It also provides more details.https://bugs.python.org/issue45464