Skip to content

bpo-44525: Specialize for calls to type and other builtin classes with 1 argument.#29942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
markshannon merged 5 commits into from
Dec 15, 2021
Merged

bpo-44525: Specialize for calls to type and other builtin classes with 1 argument. #29942

markshannon merged 5 commits into from
Dec 15, 2021

Conversation

@markshannon
Copy link
Member

@markshannonmarkshannon commented Dec 6, 2021•
edited by bedevere-bot
Loading

Fidget-Spinner
Fidget-Spinner reviewed Dec 6, 2021
View reviewed changes
Copy link
Member

@Fidget-SpinnerFidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM. Interested to see the benchmark results.

@markshannon
Copy link
MemberAuthor

markshannon commented Dec 7, 2021

Benchmark results show a slight speedup, but very close to noise.

I think this is worth including because:

  1. The nbody and spectral norm benchmarks show decent speedups and have range(arg) calls in the hot parts of the benchmark, suggesting that specialization of calls to cls(one_arg) is effective.
  2. Some "real" code includes a lot of type(obj) calls (at least statically).

Fidget-Spinner
Fidget-Spinner approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@Fidget-SpinnerFidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Python/ceval.c
assert(GET_CACHE()->adaptive.original_oparg == 1);
PyObject *obj = TOP();
PyObject *callable = SECOND();
DEOPT_IF(callable != (PyObject *)&PyType_Type, CALL_NO_KW);
Copy link
Member

@Fidget-SpinnerFidget-SpinnerDec 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember if you like using the Py_IS_TYPE inline function, but just mentioning it here and leaving it up to you :).

Copy link
MemberAuthor

@markshannonmarkshannonDec 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll skip on the obfuscation macro 🙂

Python/specialize.c
return -1;
}
if (nargs == 1){
if (tp == &PyType_Type){
Copy link
Member

@Fidget-SpinnerFidget-SpinnerDec 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

@markshannon
Copy link
MemberAuthor

markshannon commented Dec 15, 2021

Increases CALL_NO_KW hit rate from ~71% to ~74% on the standard benchmark suite, with only a slight increase in the miss rate.
Reduces failed specializations for calls to classes (SPEC_FAIL_CLASS) by over half.

@markshannonmarkshannon merged commit 3a60bfe into python:mainDec 15, 2021
@Fidget-SpinnerFidget-Spinner mentioned this pull request Sep 9, 2022
Closed
@markshannonmarkshannon deleted the specialize-calls-to-builtin-types branch September 26, 2023 12:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@markshannon@Fidget-Spinner@the-knights-who-say-ni@bedevere-bot