Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
bpo-44525: Specialize for calls to type and other builtin classes with 1 argument.#29942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
4e63a496b0738c867201282bc708ac14f9bFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Specialize the CALL_FUNCTION instruction for calls to builtin types with a | ||
| single argument. Speeds up ``range(x)``, ``list(x)``, and specifically | ||
| ``type(obj)``. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -491,8 +491,10 @@ initial_counter_value(void){ | ||
| #define SPEC_FAIL_PYCFUNCTION_NOARGS 16 | ||
| #define SPEC_FAIL_BAD_CALL_FLAGS 17 | ||
| #define SPEC_FAIL_CLASS 18 | ||
| #define SPEC_FAIL_C_METHOD_CALL 19 | ||
| #define SPEC_FAIL_METHDESCR_NON_METHOD 20 | ||
| #define SPEC_FAIL_PYTHON_CLASS 19 | ||
| #define SPEC_FAIL_C_METHOD_CALL 20 | ||
| #define SPEC_FAIL_METHDESCR_NON_METHOD 21 | ||
| #define SPEC_FAIL_METHOD_CALL_CLASS 22 | ||
| /* COMPARE_OP */ | ||
| #define SPEC_FAIL_STRING_COMPARE 13 | ||
| @@ -1263,6 +1265,27 @@ specialize_class_call( | ||
| PyObject *callable, _Py_CODEUNIT *instr, | ||
| int nargs, SpecializedCacheEntry *cache) | ||
| { | ||
| assert(PyType_Check(callable)); | ||
| PyTypeObject *tp = (PyTypeObject *)callable; | ||
| if (_Py_OPCODE(instr[-1]) == PRECALL_METHOD){ | ||
| SPECIALIZATION_FAIL(CALL_NO_KW, SPEC_FAIL_METHOD_CALL_CLASS); | ||
| return -1; | ||
| } | ||
| if (tp->tp_new == PyBaseObject_Type.tp_new){ | ||
| SPECIALIZATION_FAIL(CALL_NO_KW, SPEC_FAIL_PYTHON_CLASS); | ||
| return -1; | ||
| } | ||
| if (nargs == 1){ | ||
| if (tp == &PyType_Type){ | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto | ||
| *instr = _Py_MAKECODEUNIT(CALL_NO_KW_TYPE_1, _Py_OPARG(*instr)); | ||
| return 0; | ||
| } | ||
| if ((tp->tp_flags & Py_TPFLAGS_IMMUTABLETYPE) && tp->tp_vectorcall != NULL){ | ||
| cache->adaptive.version = tp->tp_version_tag; | ||
| *instr = _Py_MAKECODEUNIT(CALL_NO_KW_BUILTIN_CLASS_1, _Py_OPARG(*instr)); | ||
| return 0; | ||
| } | ||
| } | ||
| SPECIALIZATION_FAIL(CALL_NO_KW, SPEC_FAIL_CLASS); | ||
| return -1; | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember if you like using the
Py_IS_TYPEinline function, but just mentioning it here and leaving it up to you :).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll skip on the obfuscation macro 🙂