bpo-46198: rename duplicate tests and remove unused code

[sobolevn]

Right now, two tests have the same name:

1. cpython/Lib/test/test_email/test__header_value_parser.py

   Line 304 in 8e11237

   deftest_get_unstructured_invalid_ew(self):

2. cpython/Lib/test/test_email/test__header_value_parser.py

   Line 398 in 8e11237

   deftest_get_unstructured_invalid_ew(self):

The first one is always skipped.
I think that NEWS should not be added.

https://bugs.python.org/issue46198

[sobolevn]

test_asyncio is still failing sometimes on Windows 🤔

[sobolevn]

I am addressing feedback from https://bugs.python.org/issue46198, so I am increasing the scope of this PR to also include other similar cases. I am using flake8 with --select=F811 to find duplicates.

Amount of tests:

• test_enum: 232 -> 236
• test__header_value_parser.py: 1659 -> 1660
• test_dict: 108 -> 109
• test_compile: 101 -> 102
• test_typing: 407 -> 408

[AlexWaygood]

Title of the PR needs to change!

[sobolevn]

Rebased to solve conflicts in test_typing.

[merwok]

In general, please do merges for CPython rather than rebases and force pushes: https://devguide.python.org/pullrequest/
The reviewing experience on github is poor when there are force pushes.

[merwok]

@raghavthind2005 hello 👋🏽 Reviews by non-core developers are useful if you carefully consider the bug report, the changes, the discussions. Sometimes you need to get the branch locally, build python and try out the code to see if it does what it’s supposed to. It is useful if people who are not core devs do these things and write a message on the PR to say that. But just giving +1 without engaging with the process or the people has little value.

[JelleZijlstra]

Thanks, I'm planning to merge this (cc @gvanrossum).

The duplicate test cases are quite bad and we should definitely fix them. The duplicate imports aren't as bad but it's still cleaner to get them fixed.

[gvanrossum]

@JelleZijlstra Looks fine to me. (In general I think you don't have to CC me on things you plan to merge any more, unless you really want me to have another look. You're doing great!)

[JelleZijlstra]

Great, thanks! I was thinking of asking when I could leave new core dev quarantine :)

[miss-islington]

Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

[miss-islington]

Sorry @sobolevn and @JelleZijlstra, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6c83c8e6b56b57a8a794e7b6c07837be4ce3bb97 3.10

[miss-islington]

Sorry, @sobolevn and @JelleZijlstra, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6c83c8e6b56b57a8a794e7b6c07837be4ce3bb97 3.9

[JelleZijlstra]

I'll backport

[bedevere-bot]

GH-31797 is a backport of this pull request to the 3.9 branch.

[JelleZijlstra]

#31796 is the 3.10 backport, not sure why the bot didn't pick it up