bpo-46198: Fix test_asyncio.test_sslproto#31801
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pythonGH-30297 removed a duplicate `from test import support` statement from `test_asyncio.test_sslproto`. However, in between that PR being filed and it being merged, pythonGH-31275 removed the _other_ `from test import support` statement. This means that `support` is now undefined in `test_asyncio.test_sslproto`, causing the CI to fail on all platforms for all PRS.
JelleZijlstra approved these changes Mar 10, 2022
Member
JelleZijlstra left a comment
JelleZijlstra left a comment There was a problem hiding this comment.
oops, thanks for the catch
Member
JelleZijlstra commented Mar 10, 2022
MemberAuthor
AlexWaygood commented Mar 10, 2022
It took a little bit of detective work to figure out how it slipped through the CI! |
Member
JelleZijlstra commented Mar 10, 2022
Thanks for figuring it out! |
Member
merwok commented Mar 11, 2022
I thought we had the check enabled to prevent merging a PR that’s not up to date with the target branch! |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH-30297 removed a duplicate
from test import supportstatement fromtest_asyncio.test_sslproto. However, in between that PR being filed and it being merged, GH-31275 removed the otherfrom test import supportstatement. This means thatsupportis now undefined intest_asyncio.test_sslproto, causing the CI to fail on all platforms for all PRs (e.g. https://github.com/python/cpython/runs/5501039134?check_suite_focus=true)https://bugs.python.org/issue46198
Automerge-Triggered-By: GH:JelleZijlstra