bpo-46442: improve testExceptionCleanupNames#30758
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ericvsmith left a comment
ericvsmith left a comment There was a problem hiding this comment.
With the small noted changes, I think this is ready to commit.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented Jan 21, 2022
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
ericvsmith added needs backport to 3.9 needs backport to 3.10 The test tested that explicitly deleting the local variable bound to the exception did not cause problems, but it did not test what it actually claimed to test, i.e. that the variable is deleted automatically.
yellowdusk1590 commented Jan 21, 2022
|
bedevere-bot commented Jan 21, 2022
Thanks for making the requested changes! @ericvsmith: please review the changes made to this pull request. |
miss-islington commented Jan 22, 2022
Thanks @yellowdusk1590 for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
The test tested that explicitly deleting the local variable bound to the exception did not cause problems, but it did not test what it actually claimed to test, i.e. that the variable is deleted automatically. (cherry picked from commit 82c5322) Co-authored-by: Yellow Dusk <yellow.dusk1590@fastmail.com>
bedevere-bot commented Jan 22, 2022
GH-30778 is a backport of this pull request to the 3.10 branch. |
The test tested that explicitly deleting the local variable bound to the exception did not cause problems, but it did not test what it actually claimed to test, i.e. that the variable is deleted automatically. (cherry picked from commit 82c5322) Co-authored-by: Yellow Dusk <yellow.dusk1590@fastmail.com>
bedevere-bot commented Jan 22, 2022
GH-30779 is a backport of this pull request to the 3.9 branch. |
The test tested that explicitly deleting the local variable bound to the exception did not cause problems, but it did not test what it actually claimed to test, i.e. that the variable is deleted automatically. (cherry picked from commit 82c5322) Co-authored-by: Yellow Dusk <yellow.dusk1590@fastmail.com>
The test tested that explicitly deleting the local variable bound to the exception did not cause problems, but it did not test what it actually claimed to test, i.e. that the variable is deleted automatically. (cherry picked from commit 82c5322) Co-authored-by: Yellow Dusk <yellow.dusk1590@fastmail.com>
The test tested that explicitly deleting the local variable bound to the exception did not cause problems, but it did not test what it actually claimed to test, i.e. that the variable is deleted automatically. (cherry picked from commit 82c5322) Co-authored-by: Yellow Dusk <yellow.dusk1590@fastmail.com>
8 participants
The test tested that explicitly deleting the local variable bound to the exception
did not cause problems, but it did not test what it actually claimed to test, i.e.
that the variable is deleted automatically.
https://bugs.python.org/issue46442