[3.10] bpo-46442: improve and rename testExceptionCleanupNames (GH-30758)#30778
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The test tested that explicitly deleting the local variable bound to the exception did not cause problems, but it did not test what it actually claimed to test, i.e. that the variable is deleted automatically. (cherry picked from commit 82c5322) Co-authored-by: Yellow Dusk <yellow.dusk1590@fastmail.com>
ContributorAuthor
miss-islington commented Jan 22, 2022
@yellowdusk1590 and @ericvsmith: Status check is done, and it's a failure ❌ . |
1 similar comment
ContributorAuthor
miss-islington commented Jan 22, 2022
@yellowdusk1590 and @ericvsmith: Status check is done, and it's a failure ❌ . |
ericvsmith approved these changes Jan 22, 2022
ContributorAuthor
miss-islington commented Jan 22, 2022
@yellowdusk1590 and @ericvsmith: Status check is done, and it's a success ✅ . |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test tested that explicitly deleting the local variable bound to the exception
did not cause problems, but it did not test what it actually claimed to test, i.e.
that the variable is deleted automatically.
(cherry picked from commit 82c5322)
Co-authored-by: Yellow Dusk yellow.dusk1590@fastmail.com
https://bugs.python.org/issue46442
Automerge-Triggered-By: GH:ericvsmith