Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
bpo-46469: Make asyncio generic classes return GenericAlias#30777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
kumaraditya303 commented Jan 22, 2022 • edited by bedevere-bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-bot
Uh oh!
There was an error while loading. Please reload this page.
Misc/NEWS.d/next/Library/2022-01-22-05-05-08.bpo-46469.plUab5.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
JelleZijlstra commented Jan 22, 2022
These methods have existed since 3.9, but apparently aren't documented. Should the fix be backported? |
sobolevn left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably also add these types to
cpython/Lib/test/test_genericalias.py
Line 52 in 82c5322
| generic_types= [type, tuple, list, dict, set, frozenset, enumerate, |
kumaraditya303 commented Jan 22, 2022
This should be backported. |
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
kumaraditya303 commented Jan 22, 2022
There isn't any need to test it more than once and in the asyncio it tests both the c and python implementation so no need. |
miss-islington commented Jan 22, 2022
Thanks @kumaraditya303 for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
miss-islington commented Jan 22, 2022
Sorry, @kumaraditya303 and @asvetlov, I could not cleanly backport this to |
bedevere-bot commented Jan 22, 2022
GH-30784 is a backport of this pull request to the 3.10 branch. |
…-30777) * bpo-46469: Make asyncio generic classes return GenericAlias * 📜🤖 Added by blurb_it. * Update Misc/NEWS.d/next/Library/2022-01-22-05-05-08.bpo-46469.plUab5.rst Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit ea5b968) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
asvetlov commented Jan 22, 2022
Thanks. I'm constantly forgetting to make this change. |
bedevere-bot commented Jan 22, 2022
GH-30785 is a backport of this pull request to the 3.9 branch. |
…H-30777) (#30784) * bpo-46469: Make asyncio generic classes return GenericAlias (GH-30777) * bpo-46469: Make asyncio generic classes return GenericAlias * 📜🤖 Added by blurb_it. * Update Misc/NEWS.d/next/Library/2022-01-22-05-05-08.bpo-46469.plUab5.rst Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit ea5b968) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com> * Fix tests Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com> Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
…thonGH-30777) (pythonGH-30785) Automerge-Triggered-By: GH:asvetlov
https://bugs.python.org/issue46469