Skip to content

bpo-46483: change PurePath.__class_getitem__ to return GenericAlias#30822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
isidentical merged 1 commit into from
Jan 23, 2022
Merged

bpo-46483: change PurePath.__class_getitem__ to return GenericAlias#30822

isidentical merged 1 commit into from
Jan 23, 2022

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commented Jan 23, 2022•
edited by bedevere-bot
Loading

sobolevn
sobolevn commented Jan 23, 2022
View reviewed changes
Lib/test/test_pathlib.py
def test_complex_symlinks_relative_dot_dot(self):
self._check_complex_symlinks(os.path.join('dirA', '..'))

def test_class_getitem(self):
Copy link
MemberAuthor

@sobolevnsobolevnJan 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test now works for all _BasePathTest subclasses, previously it was only checking PurePath.

@sobolevn
Copy link
MemberAuthor

sobolevn commented Jan 23, 2022

@kumaraditya303 thanks for the review and for the idea 😉

@isidenticalisidentical merged commit 1f715d5 into python:mainJan 23, 2022
@isidentical
Copy link
Member

isidentical commented Jan 23, 2022

Thanks @sobolevn!

@sobolevnsobolevn mentioned this pull request Jan 24, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@isidenticalisidenticalisidentical approved these changes

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sobolevn@isidentical@JelleZijlstra@kumaraditya303@the-knights-who-say-ni@bedevere-bot