Skip to content

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Feb 5, 2022

The test_issue16464() test of test_urllib2 now uses
"http://httpbin.org/post" URL instead of "http://www.example.com/".

https://bugs.python.org/issue46648

The test_issue16464() test of test_urllib2 now uses "http://httpbin.org/post" URL instead of "http://www.example.com/".
@vstinner
Copy link
MemberAuthor

cc @corona10@ambv

Copy link
Member

@tirantiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a different, more reliable service. The git repo and container image of the service hasn't been maintained in years.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@vstinner
Copy link
MemberAuthor

Please use a different, more reliable service. The git repo and container image of the service hasn't been maintained in years.

test_urllib2 is failing on all buildbots right now because example.com is no longer reliable. Do you have a better suggestion?

I'm not aware of any pythontest.net URL supporting POST.

Either we switch to any other URL or the test should be skipped. Most buildbots are failing.

@orsenthil
Copy link
Member

Hi @vstinner, I am with @tiran here. If possible m we should use pythontest . I think, it supports simple post.

If blocked by external resources, we can skip the test. BTW test_urllib2net is supposed to depend on external sources. The test_urllib2 should have mocks.

@vstinnervstinner closed this Feb 6, 2022
@vstinnervstinner deleted the urllib2_issue16464 branch February 6, 2022 14:09
@vstinner
Copy link
MemberAuthor

I merged my PR #31161 instead (skip the test).

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changestestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner@bedevere-bot@orsenthil@tiran@the-knights-who-say-ni