Skip to content

Conversation

@hugovk
Copy link
Member

@hugovkhugovk commented Apr 6, 2022

Matching Devguide PR: python/devguide#826.

Also updated make -C htmlview so it used a full path with file://, because the original didn't open the page (macOS).

For example:

cd Doc # Doesn't open anything: python3 -c "import webbrowser; webbrowser.open('build/html/index.html')"# Opens the docs page e.g. file:///Users/hugo/github/cpython/Doc/build/html/index.html : python3 -c "import os, webbrowser; webbrowser.open('file://' + os.path.realpath('build/html/index.html'))"

https://bugs.python.org/issue36329

@encukou
Copy link
Member

encukou commented Apr 8, 2022

Could you make serve echo The serve target was removed, use htmlview instead (see [bpo-36329](https://bugs.python.org/issue36329)), to help anyone still using it?
Also, could you keep the example in wsgiref docs? It has a purpose there. (Maybe it could be simplified to focus on serving, better commented, and moved to Doc/, of course. But it shouldn't be removed.)

@hugovk
Copy link
MemberAuthor

Updated! How does this look?

Copy link
Member

@encukouencukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

Sorry for the delay, this fell off my list :(

@encukouencukou merged commit 89c6b2b into python:mainApr 29, 2022
@hugovkhugovk deleted the 36329-docs-make-htmlview branch April 29, 2022 15:08
@hugovk
Copy link
MemberAuthor

Thanks for the review/merge! Any chance of checking the devguide one? python/devguide#826

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@hugovk@encukou@the-knights-who-say-ni@bedevere-bot