Skip to content

gh-72719: Remove deprecated asyncore and asynchat modules#96580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 7 commits into from
Nov 8, 2022
Merged

gh-72719: Remove deprecated asyncore and asynchat modules #96580

vstinner merged 7 commits into from
Nov 8, 2022

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commented Sep 5, 2022•
edited
Loading

Several notes:

  1. I followed the same path as smtpd in gh-93243: Make smtpd private before porting its users #93246 It was suggested in Remove asyncore, asynchat and smtpd modules #72719 (comment) by @vstinner
  2. I've added TODO items about completely removing these modules in the future

PEP: https://peps.python.org/pep-0594/

@sobolevnsobolevn requested review from a team and vsajip as code ownersSeptember 5, 2022 14:18
sobolevn
sobolevn commented Sep 5, 2022
View reviewed changes
@sobolevnsobolevnforce-pushed the issue-72719 branch 2 times, most recently from 92a5bab to 97d7bc8CompareSeptember 5, 2022 14:29
theLastOfCats
theLastOfCats reviewed Sep 5, 2022
View reviewed changes
@arhadthedev
Copy link
Member

arhadthedev commented Sep 25, 2022

I think it would be great to have this PR merged before 3.12.0a1 (3 October, 2022, after 7 days) to allow third party library maintainers and early adopters to report scenarios possible in asyncore but not in asyncio as soon as possible.

@sobolevn
Copy link
MemberAuthor

sobolevn commented Sep 25, 2022

Ping @pablogsal as release manager 🙂

@pablogsal
Copy link
Member

pablogsal commented Sep 25, 2022

Ping @pablogsal as release manager 🙂

Thanks for checking with me! One note, the RM for 3.12 is @Yhg1s so he should probably also take a look

@sobolevnsobolevn added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 25, 2022
@bedevere-bot
Copy link

bedevere-bot commented Sep 25, 2022

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 99e3de9 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 25, 2022
@arhadthedevarhadthedev mentioned this pull request Oct 3, 2022
Closed
12 tasks
@arhadthedev
Copy link
Member

arhadthedev commented Oct 6, 2022

@Yhg1s Is there any chance to get this PR accepted into 3.12.0a1? It seems we've got some extra time until the release blockers are resolved.

@sobolevn@JelleZijlstra
Update Misc/NEWS.d/next/Library/2022-09-05-17-08-56.gh-issue-72719.jU…
9a49615
…pzF3.rst Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
hugovk
hugovk reviewed Oct 28, 2022
View reviewed changes
@hugovkhugovk mentioned this pull request Oct 28, 2022
Closed
@sobolevnsobolevn mentioned this pull request Oct 29, 2022
Merged
vstinner
vstinner reviewed Nov 3, 2022
View reviewed changes
Misc/NEWS.d/next/Library/2022-09-05-17-08-56.gh-issue-72719.jUpzF3.rst Outdated
@@ -0,0 +1,3 @@
Remove modules :mod:`asyncore` and :mod:`asynchat`, which were deprecated by :pep:`594`.

They are temporarily moved to :mod:`test.support` so some other tests that rely on them keep working.
Copy link
Member

@vstinnervstinnerNov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to remove the second sentence. I prefer to hide them as well as possible :-)

Copy link
MemberAuthor

@sobolevnsobolevnNov 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thank you for the review!

@bedevere-botbedevere-bot mentioned this pull request Nov 5, 2022
Closed
vstinner
vstinner reviewed Nov 7, 2022
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove last references:

  • Doc/library/socketserver.rst
  • Doc/license.rst: update the module names

@giampaolo: Would you be ok to be removed from github/CODEOWNERS for asyncore/asynchat, so these files should not longer be updated but just die?

@vstinner
Copy link
Member

vstinner commented Nov 7, 2022

When I removed the module last year (commit), I even renamed the asyncore module to test.support._asyncore. But I don't mind to call it test.support.asyncore.

@giampaolo
Copy link
Contributor

giampaolo commented Nov 7, 2022

@giampaolo: Would you be ok to be removed from github/CODEOWNERS for asyncore/asynchat, so these files should not longer be updated but just die?

sure, no problem

@sobolevn
Copy link
MemberAuthor

sobolevn commented Nov 7, 2022

Done, all three - removed!

vstinner
vstinner reviewed Nov 7, 2022
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, there is now a conflict. Can you try to rebase your PR? Or try to merge main into your PR?

Please keep the license, files are still around, they are just moved somewhere else.

vstinner
vstinner approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinnervstinner merged commit e56e33d into python:mainNov 8, 2022
@vstinner
Copy link
Member

vstinner commented Nov 8, 2022

Merged, thanks. Let's see how it goes with Python 3.12.

@sobolevn
Copy link
MemberAuthor

sobolevn commented Nov 8, 2022

Thank you for your guidance and help!
I feel happy now, removing old stuff is my kinda thing 😊 🎉

@vstinner
Copy link
Member

vstinner commented Nov 8, 2022

See also the discussion: Collaboration on handling Python 3.12 incompatible changes (distutils removal, invalid escape escape, etc.).

@opoplawskiopoplawski mentioned this pull request Apr 1, 2023
Closed
@arhadthedevarhadthedev mentioned this pull request May 25, 2023
Closed
@hongleihonglei mentioned this pull request Jun 18, 2023
Closed
@thebeanogamerthebeanogamer mentioned this pull request Jul 16, 2023
Open
SreekanthModupalli

This comment was marked as off-topic.

Sign in to view

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra left review comments

@hugovkhugovkhugovk left review comments

@vstinnervstinnervstinner approved these changes

@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

@giampaologiampaoloAwaiting requested review from giampaologiampaolo is a code owner

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

+2 more reviewers

@theLastOfCatstheLastOfCatstheLastOfCats left review comments

@SreekanthModupalliSreekanthModupalliSreekanthModupalli left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@sobolevn@arhadthedev@pablogsal@bedevere-bot@vstinner@giampaolo@JelleZijlstra@hugovk@theLastOfCats@SreekanthModupalli