Skip to content

asyncore and asynchat will be removed in 3.12#9033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
srittau merged 3 commits into from
May 23, 2023
Merged

asyncore and asynchat will be removed in 3.12 #9033

srittau merged 3 commits into from
May 23, 2023

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commented Oct 29, 2022

AlexWaygood
AlexWaygood previously requested changes Oct 29, 2022
View reviewed changes
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last version in the "version ranges" in this file is the "last version when the module was available" :)

@AlexWaygood
Copy link
Member

AlexWaygood commented Oct 29, 2022

I'm also not sure if we should do this before the runtime PR's been merged? But don't have a strong opinion either way on that.

@sobolevn@AlexWaygood
Apply suggestions from code review
aff8dab
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@github-actions

This comment has been minimized.

Sign in to view
@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Oct 29, 2022•
edited
Loading

I think stubtest might not complain about missing stubs for stdlib modules, so this is best done when betas are released (in case the removal is undone)

@AlexWaygood
Copy link
Member

AlexWaygood commented Oct 29, 2022

I think stubtest might not complain about missing stubs for stdlib modules

That's correct, it doesn't

@AlexWaygoodAlexWaygood added the status: deferred Issue or PR deferred until some precondition is fixed label Oct 29, 2022
@AlexWaygoodAlexWaygood marked this pull request as draft October 30, 2022 11:07
@AlexWaygoodAlexWaygood changed the title asyncore and asynchat will be removed in 3.12[Wait until 3.12 betas] asyncore and asynchat will be removed in 3.12Oct 31, 2022
@sobolevnsobolevn removed the status: deferred Issue or PR deferred until some precondition is fixed label May 23, 2023
@sobolevnsobolevn marked this pull request as ready for review May 23, 2023 16:34
@sobolevnsobolevn changed the title [Wait until 3.12 betas] asyncore and asynchat will be removed in 3.12asyncore and asynchat will be removed in 3.12May 23, 2023
@sobolevn
Copy link
MemberAuthor

sobolevn commented May 23, 2023

Beta 1 is out! 👍

@github-actions
Copy link
Contributor

github-actionsbot commented May 23, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittausrittau merged commit e666602 into python:mainMay 23, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn@AlexWaygood@hauntsaninja@srittau