Skip to content

Conversation

@StanFromIreland
Copy link
Member

@StanFromIrelandStanFromIreland commented Jun 23, 2025

This page is aimed at coordinators, so I assume some git/gh knowledge etc.

Some things that need to be discussed:

closes#1586


📚 Documentation preview 📚: https://cpython-devguide--1587.org.readthedocs.build/

@StanFromIreland
Copy link
MemberAuthor

StanFromIreland commented Jun 24, 2025

While this has to wait for a pending issue, other discussion should continue. These are comments I left in the file in the format, XXX thought.

Requesting @rffontenelle and @m-aciek

@StanFromIrelandStanFromIreland marked this pull request as ready for review June 24, 2025 19:06
Copy link
Contributor

@rffontenellerffontenelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the docs. Please find some notes below

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

@StanFromIreland
Copy link
MemberAuthor

Thanks for the review.

I should have my editor highlight it in red:-)

@StanFromIreland
Copy link
MemberAuthor

StanFromIreland commented Aug 5, 2025

Since this pr is taking a while (due to it's size already), we can leave the todos that need discussion to follow ups. Would it be possible to get a review @willingc?

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@StanFromIreland
Copy link
MemberAuthor

Thanks for making them suggestions!

@willingc
Copy link
Collaborator

Thanks @hugovk for reviewing. I tried to review this morning and hit 500 errors from GitHub. Will review now.

Copy link
Collaborator

@willingcwillingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @StanFromIreland for making these changes.

@StanFromIreland
Copy link
MemberAuthor

Anything left to do to get this merged?

@encukouencukou merged commit b0aefe9 into python:mainAug 18, 2025
4 checks passed
@StanFromIrelandStanFromIreland deleted the coordinating branch August 18, 2025 14:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

7 participants

@StanFromIreland@willingc@hugovk@rffontenelle@m-aciek@ezio-melotti@encukou