Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 201
Skip 3.12-dev pending Greenlet support#259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
hugovk commented Jan 11, 2023 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
hugovk commented Jan 15, 2023
Need to research more about how I also removed unsupported |
hugovk commented Feb 5, 2023
Please see PR #264 to replace this. |
| # Skip 3.12-dev, pending https://github.com/python-greenlet/greenlet/issues/323 | ||
| python: [pypy3.8, pypy3.9, "3.7", "3.8", "3.9", "3.10", 3.11-dev] |
pradyunsgFeb 5, 2023 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm understanding https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#handling-failures correctly, we can achieve what we want to with something like:
continue-on-error: ${{matrix.failure-allowed }}strategy: fail-fast: falsematrix: # Test all supported versions on Ubuntu:os: [ubuntu-latest]python: [pypy3.8, pypy3.9, "3.7", "3.8", "3.9", "3.10", 3.11-dev]failure-allowed: [false]include: # Also test macOS and Windows: - os: macos-latestpython: "3.10"failure-allowed: false - os: windows-latestpython: "3.10"failure-allowed: false# Also test in-development version (allowing failures): - os: ubuntu-latestpython: "3.12-dev"failure-allowed: trueThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
failure-allowed is a verb/phrase that we can change as we wish to communicate things via the variable name. The example from GitHub used experimental.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I did try something along those lines, but wasn't successful.
Although I think #264 is a better approach? Then we'll at least see if the non-greenlet tests fail for 3.12. And when greenlet installs for 3.12, it'll start testing those too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at your force-pushed events' diffs, I don't see continue-on-error: ${{matrix.failure-allowed }} being added at any point at the job.<id> level; which might be why they didn't work?
Regardless, they're both valid approaches to solving the problem so it's not a big deal which one we go with. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also tried it in another branch:
test: runs-on: ${{matrix.os }}name: ${{matrix.os }} - ${{matrix.python }}continue-on-error: ${{matrix.experimental }}strategy: fail-fast: falsematrix: # Test all supported versions on Ubuntu:os: [ubuntu-latest]python: [pypy3.7, pypy3.8, pypy3.9, "3.7", "3.8", "3.9", "3.10", 3.11-dev]experimental: [false]include: # Also test macOS and Windows: - os: macos-latestpython: "3.10"experimental: false - os: windows-latestpython: "3.10"experimental: false# Allow 3.12-dev to fail pending https://github.com/python-greenlet/greenlet/issues/323 - os: ubuntu-latestpython: 3.12-devexperimental: trueVery similar to your snippet:
But still failed a PR: hugovk#3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed! Thanks for clarifying! ^.^
hugovk commented Apr 20, 2023
Closed in favour of #274 👍 |

At the moment the
3.12-devbuilds are failing, causing every build to show as failed.It's failing because Greenlet doesn't yet support 3.12. The tracking issue is at python-greenlet/greenlet#323 and there's a PR at python-greenlet/greenlet#327 but it's not ready yet.
In the meantime, we can mark
3.12-devas "experimental", so whilst the individual job still fails, it doesn't mark the whole build as failed.Docs: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idcontinue-on-error
Also bump GitHub Actions, allow building feature branches, and we can fold the PyPy config into the main list.
workflow_dispatchadds a button to the UI to be able to trigger new builds, occasionally useful.Shall we also remove
pypy3.7? The newest PyPy only supports 3.8 and 3.9: