Skip to content

Conversation

@hugovk
Copy link
Member

@hugovkhugovk commented Jan 11, 2023

At the moment the 3.12-dev builds are failing, causing every build to show as failed.

It's failing because Greenlet doesn't yet support 3.12. The tracking issue is at python-greenlet/greenlet#323 and there's a PR at python-greenlet/greenlet#327 but it's not ready yet.

In the meantime, we can mark 3.12-dev as "experimental", so whilst the individual job still fails, it doesn't mark the whole build as failed.

Docs: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idcontinue-on-error


Also bump GitHub Actions, allow building feature branches, and we can fold the PyPy config into the main list. workflow_dispatch adds a button to the UI to be able to trigger new builds, occasionally useful.


Shall we also remove pypy3.7? The newest PyPy only supports 3.8 and 3.9:

@hugovk

This comment was marked as outdated.

@hugovkhugovk marked this pull request as draft January 12, 2023 07:31
@hugovkhugovk changed the title Allow 3.12-dev to fail pending Greenlet supportSkip 3.12-dev pending Greenlet supportJan 15, 2023
@hugovk
Copy link
MemberAuthor

Need to research more about how continue-on-error works, for now I think it's fine to remove the failing 3.12-dev from the matrix until python-greenlet/greenlet#323 is resolved.

I also removed unsupported pypy3.7.

@hugovkhugovk marked this pull request as ready for review January 15, 2023 16:05
@hugovk
Copy link
MemberAuthor

Please see PR #264 to replace this.

Comment on lines +21 to +22
# Skip 3.12-dev, pending https://github.com/python-greenlet/greenlet/issues/323
python: [pypy3.8, pypy3.9, "3.7", "3.8", "3.9", "3.10", 3.11-dev]
Copy link
Member

@pradyunsgpradyunsgFeb 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm understanding https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#handling-failures correctly, we can achieve what we want to with something like:

continue-on-error: ${{matrix.failure-allowed }}strategy: fail-fast: falsematrix: # Test all supported versions on Ubuntu:os: [ubuntu-latest]python: [pypy3.8, pypy3.9, "3.7", "3.8", "3.9", "3.10", 3.11-dev]failure-allowed: [false]include: # Also test macOS and Windows: - os: macos-latestpython: "3.10"failure-allowed: false - os: windows-latestpython: "3.10"failure-allowed: false# Also test in-development version (allowing failures): - os: ubuntu-latestpython: "3.12-dev"failure-allowed: true

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failure-allowed is a verb/phrase that we can change as we wish to communicate things via the variable name. The example from GitHub used experimental.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I did try something along those lines, but wasn't successful.

Although I think #264 is a better approach? Then we'll at least see if the non-greenlet tests fail for 3.12. And when greenlet installs for 3.12, it'll start testing those too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at your force-pushed events' diffs, I don't see continue-on-error: ${{matrix.failure-allowed }} being added at any point at the job.<id> level; which might be why they didn't work?

Regardless, they're both valid approaches to solving the problem so it's not a big deal which one we go with. :)

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tried it in another branch:

test: runs-on: ${{matrix.os }}name: ${{matrix.os }} - ${{matrix.python }}continue-on-error: ${{matrix.experimental }}strategy: fail-fast: falsematrix: # Test all supported versions on Ubuntu:os: [ubuntu-latest]python: [pypy3.7, pypy3.8, pypy3.9, "3.7", "3.8", "3.9", "3.10", 3.11-dev]experimental: [false]include: # Also test macOS and Windows: - os: macos-latestpython: "3.10"experimental: false - os: windows-latestpython: "3.10"experimental: false# Allow 3.12-dev to fail pending https://github.com/python-greenlet/greenlet/issues/323 - os: ubuntu-latestpython: 3.12-devexperimental: true

Very similar to your snippet:

image

But still failed a PR: hugovk#3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! Thanks for clarifying! ^.^

@hugovk
Copy link
MemberAuthor

Closed in favour of #274 👍

@hugovkhugovk closed this Apr 20, 2023
@hugovkhugovk deleted the ci-update branch April 20, 2023 22:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hugovk@pradyunsg