Skip to content

Skip 3.12-dev pending Greenlet support#259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hugovk wants to merge 4 commits into from
Closed

Skip 3.12-dev pending Greenlet support #259

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be5fdf7
Refactor: PyPy into matrix with others on ubuntu-latest
hugovk Jan 11, 2023
8e43134
Bump GitHub Actions
hugovk Jan 11, 2023
fcaf941
Skip 3.12-dev pending Greenlet support
hugovk Jan 15, 2023
23663df
Remove unsupported pypy3.7
hugovk Jan 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,12 +2,11 @@ name: test

on:
push:
branches: [main]
pull_request:
branches: [main]
schedule:
# Midnight UTC:
- cron: "0 0 * * *"
workflow_dispatch:

jobs:

Expand All@@ -19,28 +18,23 @@ jobs:
matrix:
# Test all supported versions on Ubuntu:
os: [ubuntu-latest]
python: ["3.7", "3.8", "3.9", "3.10", 3.11-dev, 3.12-dev]
# Skip 3.12-dev, pending https://github.com/python-greenlet/greenlet/issues/323
python: [pypy3.8, pypy3.9, "3.7", "3.8", "3.9", "3.10", 3.11-dev]
Comment on lines +21 to +22
Copy link
Member

@pradyunsgpradyunsgFeb 5, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm understanding https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#handling-failures correctly, we can achieve what we want to with something like:

continue-on-error: ${{matrix.failure-allowed }}strategy: fail-fast: falsematrix: # Test all supported versions on Ubuntu:os: [ubuntu-latest]python: [pypy3.8, pypy3.9, "3.7", "3.8", "3.9", "3.10", 3.11-dev]failure-allowed: [false]include: # Also test macOS and Windows: - os: macos-latestpython: "3.10"failure-allowed: false - os: windows-latestpython: "3.10"failure-allowed: false# Also test in-development version (allowing failures): - os: ubuntu-latestpython: "3.12-dev"failure-allowed: true

Copy link
Member

@pradyunsgpradyunsgFeb 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failure-allowed is a verb/phrase that we can change as we wish to communicate things via the variable name. The example from GitHub used experimental.

Copy link
MemberAuthor

@hugovkhugovkFeb 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I did try something along those lines, but wasn't successful.

Although I think #264 is a better approach? Then we'll at least see if the non-greenlet tests fail for 3.12. And when greenlet installs for 3.12, it'll start testing those too.

Copy link
Member

@pradyunsgpradyunsgFeb 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at your force-pushed events' diffs, I don't see continue-on-error: ${{matrix.failure-allowed }} being added at any point at the job.<id> level; which might be why they didn't work?

Regardless, they're both valid approaches to solving the problem so it's not a big deal which one we go with. :)

Copy link
MemberAuthor

@hugovkhugovkFeb 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tried it in another branch:

test: runs-on: ${{matrix.os }}name: ${{matrix.os }} - ${{matrix.python }}continue-on-error: ${{matrix.experimental }}strategy: fail-fast: falsematrix: # Test all supported versions on Ubuntu:os: [ubuntu-latest]python: [pypy3.7, pypy3.8, pypy3.9, "3.7", "3.8", "3.9", "3.10", 3.11-dev]experimental: [false]include: # Also test macOS and Windows: - os: macos-latestpython: "3.10"experimental: false - os: windows-latestpython: "3.10"experimental: false# Allow 3.12-dev to fail pending https://github.com/python-greenlet/greenlet/issues/323 - os: ubuntu-latestpython: 3.12-devexperimental: true

Very similar to your snippet:

image

But still failed a PR: hugovk#3

Copy link
Member

@pradyunsgpradyunsgFeb 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! Thanks for clarifying! ^.^

include:
# Also test PyPy, macOS, and Windows:
- os: ubuntu-latest
python: pypy-3.9
- os: ubuntu-latest
python: pypy-3.8
- os: ubuntu-latest
python: pypy-3.7
# Also test macOS and Windows:
- os: macos-latest
python: "3.10"
- os: windows-latest
python: "3.10"
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Set up Python ${{matrix.python }}
uses: actions/setup-python@v2
uses: actions/setup-python@v4
if: "!endsWith(matrix.python, '-dev')"
with:
python-version: ${{matrix.python }}
- name: Set up Python ${{matrix.python }} using deadsnakes
uses: deadsnakes/action@v2.1.1
uses: deadsnakes/action@v3.0.0
if: "endsWith(matrix.python, '-dev')"
with:
python-version: ${{matrix.python }}
Expand Down