Skip to content

sqlite3: add 3.11 additions#7625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
srittau merged 5 commits into from
Apr 16, 2022
Merged

sqlite3: add 3.11 additions #7625

srittau merged 5 commits into from
Apr 16, 2022

Conversation

@JelleZijlstra
Copy link
Member

@JelleZijlstraJelleZijlstra commented Apr 15, 2022

@JelleZijlstra
sqlite3: add 3.11 additions
0ba23bb
- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged) - Aggregate window functions from python/cpython#20903 - Serialize/deserialize from python/cpython#26728 - Limit setting from python/cpython#28463
@github-actions

This comment has been minimized.

Sign in to view
srittau
srittau requested changes Apr 15, 2022
View reviewed changes
Copy link
Collaborator

@srittausrittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting changes to sqlite!

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood requested changes Apr 16, 2022
View reviewed changes
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos :)

AlexWaygood
AlexWaygood reviewed Apr 16, 2022
View reviewed changes
stdlib/sqlite3/dbapi2.pyi
defseek(self, __offset: int, __whence: int= ...) ->None: ...
def__len__(self) ->int: ...
def__enter__(self: Self) ->Self: ...
def__exit__(self, __typ: object, __val: object, __tb: object) ->Literal[False]: ...
Copy link
Member

@AlexWaygoodAlexWaygoodApr 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is going to anger my unreleased Y036 check over at flake8-pyi :/ PyCQA/flake8-pyi@b7f7e9a

Copy link
MemberAuthor

@JelleZijlstraJelleZijlstraApr 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, do you think we should change it? This __exit__ method really does take object; that's what the AC annotations say.

Copy link
Member

@AlexWaygoodAlexWaygoodApr 16, 2022•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Kay, I'll work up a patch for flake8-pyi. It should be fine to merge this before flake8-pyi is fixed.

srittau
srittau approved these changes Apr 16, 2022
View reviewed changes
Copy link
Collaborator

@srittausrittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from the things @AlexWaygood pointed out.

AlexWaygood
AlexWaygood approved these changes Apr 16, 2022
View reviewed changes
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos have been corrected to my satisfaction :)

@github-actions
Copy link
Contributor

github-actionsbot commented Apr 16, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittausrittau merged commit d802e65 into python:masterApr 16, 2022
@JelleZijlstraJelleZijlstra deleted the sqlite branch April 16, 2022 14:09
@AlexWaygoodAlexWaygood mentioned this pull request Apr 16, 2022
Merged
@AlexWaygoodAlexWaygood mentioned this pull request Jan 17, 2023
Merged
@AlexWaygoodAlexWaygood mentioned this pull request Feb 25, 2023
Merged
@srittausrittau mentioned this pull request Jun 24, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittausrittausrittau approved these changes

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JelleZijlstra@srittau@AlexWaygood