Fast forward resolved/rejected promises with fibers await#18
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
WyriHaximusforce-pushed the fibers-fastforward-resolved-promise branch from fbca226 to 517da31Compare
clue reviewed Dec 21, 2021
Member
clue left a comment
clue left a comment There was a problem hiding this comment.
@WyriHaximus Makes a lot of sense!
Looking forward to also seeing similar changes in the v2/v3 branches 👍
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
WyriHaximusforce-pushed the fibers-fastforward-resolved-promise branch 5 times, most recently from ed262a9 to eb47800Compare
MemberAuthor
WyriHaximus commented Dec 24, 2021
@clue Once this one lands, I'll port it to the v2 and v3 branches. |
This makes `await`ing an already resolved promise significantly faster.
WyriHaximusforce-pushed the fibers-fastforward-resolved-promise branch from eb47800 to 546cb73Compareclue approved these changes Jan 5, 2022
Member
clue left a comment
clue left a comment There was a problem hiding this comment.
@WyriHaximus Thanks for the update, changes LGTM! 
WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Jan 10, 2022
This makes `await`ing an already resolved promise significantly faster. Ported from: reactphp#18
WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Jan 10, 2022
This makes `await`ing an already resolved promise significantly faster. Ported from: reactphp#18
WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Jan 10, 2022
This makes `await`ing an already resolved promise significantly faster. Ported from: reactphp#18
This was referenced Jan 10, 2022
WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Jan 14, 2022
This makes `await`ing an already resolved promise significantly faster. Ported from: reactphp#18
WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Jan 17, 2022
This makes `await`ing an already resolved promise significantly faster. Ported from: reactphp#18
WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Jan 17, 2022
This makes `await`ing an already resolved promise significantly faster. Ported from: reactphp#18
WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Jan 25, 2022
This makes `await`ing an already resolved promise significantly faster. Ported from: reactphp#18
WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Jan 25, 2022
This makes `await`ing an already resolved promise significantly faster. Ported from: reactphp#18
WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Jan 25, 2022
This makes `await`ing an already resolved promise significantly faster. Ported from: reactphp#18
WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Jan 25, 2022
This makes `await`ing an already resolved promise significantly faster. Ported from: reactphp#18
WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Feb 11, 2022
This makes `await`ing an already resolved promise significantly faster. Ported from: reactphp#18
WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Feb 11, 2022
This makes `await`ing an already resolved promise significantly faster. Ported from: reactphp#18
WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Feb 11, 2022
This makes `await`ing an already resolved promise significantly faster. Ported from: reactphp#18
WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Feb 11, 2022
This makes `await`ing an already resolved promise significantly faster. Ported from: reactphp#18
WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Feb 11, 2022
This makes `await`ing an already resolved promise significantly faster. Ported from: reactphp#18
WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Feb 11, 2022
This makes `await`ing an already resolved promise significantly faster. Ported from: reactphp#18
WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Feb 11, 2022
This makes `await`ing an already resolved promise significantly faster. Ported from: reactphp#18
WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Feb 11, 2022
This makes `await`ing an already resolved promise significantly faster. Ported from: reactphp#18
WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Feb 11, 2022
This makes `await`ing an already resolved promise significantly faster. Ported from: reactphp#18
WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Feb 11, 2022
This makes `await`ing an already resolved promise significantly faster. Ported from: reactphp#18
WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Feb 20, 2022
Since `async()` returns a promise and those are normally cancelable, implementing this puts them in line with the rest of our ecosystem. As such the following example will throw a timeout exception from the canceled `sleep()` call. ```php $promise = async(static function (): int{echo 'a'; await(sleep(2)); echo 'b'; return time()})(); $promise->cancel(); await($promise); ```` This builds on top of reactphp#15, reactphp#18, reactphp#19, reactphp#26, reactphp#28, reactphp#30, and reactphp#32.WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Feb 21, 2022
Since `async()` returns a promise and those are normally cancelable, implementing this puts them in line with the rest of our ecosystem. As such the following example will throw a timeout exception from the canceled `sleep()` call. ```php $promise = async(static function (): int{echo 'a'; await(sleep(2)); echo 'b'; return time()})(); $promise->cancel(); await($promise); ```` This builds on top of reactphp#15, reactphp#18, reactphp#19, reactphp#26, reactphp#28, reactphp#30, and reactphp#32.WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Feb 21, 2022
Since `async()` returns a promise and those are normally cancelable, implementing this puts them in line with the rest of our ecosystem. As such the following example will throw a timeout exception from the canceled `sleep()` call. ```php $promise = async(static function (): int{echo 'a'; await(sleep(2)); echo 'b'; return time()})(); $promise->cancel(); await($promise); ```` This builds on top of reactphp#15, reactphp#18, reactphp#19, reactphp#26, reactphp#28, reactphp#30, and reactphp#32.WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Feb 24, 2022
Since `async()` returns a promise and those are normally cancelable, implementing this puts them in line with the rest of our ecosystem. As such the following example will throw a timeout exception from the canceled `sleep()` call. ```php $promise = async(static function (): int{echo 'a'; await(sleep(2)); echo 'b'; return time()})(); $promise->cancel(); await($promise); ```` This builds on top of reactphp#15, reactphp#18, reactphp#19, reactphp#26, reactphp#28, reactphp#30, and reactphp#32.WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Feb 24, 2022
Since `async()` returns a promise and those are normally cancelable, implementing this puts them in line with the rest of our ecosystem. As such the following example will throw a timeout exception from the canceled `sleep()` call. ```php $promise = async(static function (): int{echo 'a'; await(sleep(2)); echo 'b'; return time()})(); $promise->cancel(); await($promise); ```` This builds on top of reactphp#15, reactphp#18, reactphp#19, reactphp#26, reactphp#28, reactphp#30, and reactphp#32.WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Mar 2, 2022
Since `async()` returns a promise and those are normally cancelable, implementing this puts them in line with the rest of our ecosystem. As such the following example will throw a timeout exception from the canceled `sleep()` call. ```php $promise = async(static function (): int{echo 'a'; await(sleep(2)); echo 'b'; return time()})(); $promise->cancel(); await($promise); ```` This builds on top of reactphp#15, reactphp#18, reactphp#19, reactphp#26, reactphp#28, reactphp#30, and reactphp#32.WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Mar 3, 2022
Since `async()` returns a promise and those are normally cancelable, implementing this puts them in line with the rest of our ecosystem. As such the following example will throw a timeout exception from the canceled `sleep()` call. ```php $promise = async(static function (): int{echo 'a'; await(sleep(2)); echo 'b'; return time()})(); $promise->cancel(); await($promise); ```` This builds on top of reactphp#15, reactphp#18, reactphp#19, reactphp#26, reactphp#28, reactphp#30, and reactphp#32.WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Mar 3, 2022
Since `async()` returns a promise and those are normally cancelable, implementing this puts them in line with the rest of our ecosystem. As such the following example will throw a timeout exception from the canceled `sleep()` call. ```php $promise = async(static function (): int{echo 'a'; await(sleep(2)); echo 'b'; return time()})(); $promise->cancel(); await($promise); ```` This builds on top of reactphp#15, reactphp#18, reactphp#19, reactphp#26, reactphp#28, reactphp#30, and reactphp#32.WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Mar 4, 2022
Since `async()` returns a promise and those are normally cancelable, implementing this puts them in line with the rest of our ecosystem. As such the following example will throw a timeout exception from the canceled `sleep()` call. ```php $promise = async(static function (): int{echo 'a'; await(sleep(2)); echo 'b'; return time()})(); $promise->cancel(); await($promise); ```` This builds on top of reactphp#15, reactphp#18, reactphp#19, reactphp#26, reactphp#28, reactphp#30, and reactphp#32.WyriHaximus added a commit to WyriHaximus-labs/async that referenced this pull request Mar 4, 2022
Since `async()` returns a promise and those are normally cancelable, implementing this puts them in line with the rest of our ecosystem. As such the following example will throw a timeout exception from the canceled `sleep()` call. ```php $promise = async(static function (): int{echo 'a'; await(sleep(2)); echo 'b'; return time()})(); $promise->cancel(); await($promise); ```` This builds on top of reactphp#15, reactphp#18, reactphp#19, reactphp#26, reactphp#28, reactphp#30, and reactphp#32.Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
awaiting an already resolved promise significantly faster.