[2.x] Fast forward resolved/rejected promises with await#21
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
WyriHaximusforce-pushed the 2.x--fastforward-resolved-promise branch 2 times, most recently from c30cebf to 6e0444cCompare
clue reviewed Jan 25, 2022
Uh oh!
There was an error while loading. Please reload this page.
WyriHaximusforce-pushed the 2.x--fastforward-resolved-promise branch 2 times, most recently from fe531c7 to 2854f1fCompareWyriHaximusforce-pushed the 2.x--fastforward-resolved-promise branch 5 times, most recently from a2deae8 to 08a009eCompare
This makes `await`ing an already resolved promise significantly faster. Ported from: reactphp#18
WyriHaximusforce-pushed the 2.x--fastforward-resolved-promise branch from 08a009e to 5b572feCompare
MemberAuthor
WyriHaximus commented Feb 23, 2022
After discussing this PR with @SimonFrings and @clue we came to the conclusion that porting #18 to #22 and this PR doesn't introduce only more code and no performance gainst at all. We got a bit excited about the idea of doing this without realizing this makes the function more complex while the loop would instantly be stopped anyway. And that fraction of a millisecond gain we might get from doing this is not worth it. It was however very much worth doing this for fibers in #18. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
awaiting an already resolved promise significantly faster.Ported from: #18