Skip to content

Skip cancellation of promise within Fiber without cancellation support#34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
WyriHaximus merged 1 commit into from
Mar 4, 2022
Merged

Skip cancellation of promise within Fiber without cancellation support #34

WyriHaximus merged 1 commit into from
Mar 4, 2022

Conversation

@clue
Copy link
Member

@clueclue commented Mar 4, 2022

This changeset makes sure we skip cancellation of promises within Fiber instances that do not have cancellation support. This improves interoperability by supporting custom or foreign Fiber instances not coming from our async() function.

Builds on top of #20

@clueclue added the new feature New feature or request label Mar 4, 2022
@clueclue self-assigned this Mar 4, 2022
@clueclue added this to the v4.0.0 milestone Mar 4, 2022
@clueclue mentioned this pull request Mar 4, 2022
Merged
@clueclue requested a review from WyriHaximusMarch 4, 2022 11:07
@WyriHaximusWyriHaximus merged commit 0ba9f70 into reactphp:4.xMar 4, 2022
@clueclue deleted the skip-unsupported-cancellation branch March 4, 2022 12:32
@clueclue mentioned this pull request Jun 29, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WyriHaximusWyriHaximusWyriHaximus approved these changes

@SimonFringsSimonFringsSimonFrings approved these changes

Assignees

@clueclue

Labels

new featureNew feature or request

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@clue@WyriHaximus@SimonFrings