Skip to content

Conversation

@clue
Copy link
Member

@clueclue commented Jun 29, 2022

This changeset ensures we're using consistent cancellation semantics for async() and coroutine(). In particular, calling cancel() on the resulting promise will now try to cancel the first pending operation only. Cancelling a pending operation would usually throw an exception and thus reject the resulting promise. If this exception in caught inside the fiber/coroutine and another operation is started or if the pending operation does not support cancellation, the fiber/coroutine may continue executing.

Refs #42
Changes for coroutine() cherry-picked from #54 for 3.x, but also refs cancellation of async() (see #20 and #34)
Builds on top of #20, #34 and #48

@clueclue added new feature New feature or request BC break labels Jun 29, 2022
@clueclue added this to the v4.0.0 milestone Jun 29, 2022
@clueclue requested a review from WyriHaximusJune 29, 2022 11:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BC breaknew featureNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@clue@WyriHaximus